From 7669295a9272164aa2d15e0519cd25c949050c3e Mon Sep 17 00:00:00 2001 From: Joan Fontanals Martinez Date: Thu, 28 Sep 2023 17:54:55 +0200 Subject: [PATCH] test: remove skips Signed-off-by: Joan Fontanals Martinez --- tests/units/array/test_array_from_to_pandas.py | 2 -- tests/units/document/test_base_document.py | 1 - tests/units/util/test_filter.py | 4 ---- 3 files changed, 7 deletions(-) diff --git a/tests/units/array/test_array_from_to_pandas.py b/tests/units/array/test_array_from_to_pandas.py index 68917f48a71..d89902c2f8a 100644 --- a/tests/units/array/test_array_from_to_pandas.py +++ b/tests/units/array/test_array_from_to_pandas.py @@ -6,7 +6,6 @@ from docarray import BaseDoc, DocList, DocVec from docarray.documents import ImageDoc from docarray.typing import NdArray, TorchTensor -from docarray.utils._internal.pydantic import is_pydantic_v2 @pytest.fixture() @@ -136,7 +135,6 @@ class BasisUnion(BaseDoc): assert docs_copy == docs_basic -@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2") @pytest.mark.parametrize('tensor_type', [NdArray, TorchTensor]) def test_from_to_pandas_tensor_type(tensor_type): class MyDoc(BaseDoc): diff --git a/tests/units/document/test_base_document.py b/tests/units/document/test_base_document.py index 018ccf44d4a..09c9a0660a4 100644 --- a/tests/units/document/test_base_document.py +++ b/tests/units/document/test_base_document.py @@ -6,7 +6,6 @@ from docarray import DocList, DocVec from docarray.base_doc.doc import BaseDoc from docarray.typing import NdArray -from docarray.utils._internal.pydantic import is_pydantic_v2 def test_base_document_init(): diff --git a/tests/units/util/test_filter.py b/tests/units/util/test_filter.py index d8c59bd54ff..417bde4232e 100644 --- a/tests/units/util/test_filter.py +++ b/tests/units/util/test_filter.py @@ -5,7 +5,6 @@ from docarray import BaseDoc, DocList from docarray.documents import ImageDoc, TextDoc -from docarray.utils._internal.pydantic import is_pydantic_v2 from docarray.utils.filter import filter_docs @@ -244,9 +243,6 @@ def test_logic_filter(docs, dict_api): assert len(result) == 3 -@pytest.mark.skipif( - is_pydantic_v2, reason="Not working with pydantic v2" -) # TextDoc validation with string is not working with pydantic v2 @pytest.mark.parametrize('dict_api', [True, False]) def test_from_docstring(dict_api): class MyDocument(BaseDoc):