Activity

1. samsja

   added this to DocArray backlogon Sep 13, 2023
2. samsja

   converted this from a draft issue on Sep 13, 2023
3. punndcoder28 commented on Sep 14, 2023

   

   punndcoder28

   on Sep 14, 2023

   Contributor

   More actions

   Hi @samsja I can work on this. From the docs I understand that the correct way is

   from docarray import DocList, BaseDoc
   
   class MyDoc(BaseDoc):
       text: str
   
   docs = DocList[BaseDoc]([MyDoc])
   
4. samsja commented on Sep 15, 2023

   

   samsja

   on Sep 15, 2023

   MemberAuthor

   More actions

   Yes exactly, the problem is that if you do DocList[BaseDoc()] it will work but it should not
5. punndcoder28 commented on Sep 15, 2023

   

   punndcoder28

   on Sep 15, 2023

   Contributor

   More actions

   Understood. Will go through the custom implementation of safe_issubclass method and propose a solution for this issue
6. JoanFM commented on Sep 15, 2023

   

   JoanFM

   on Sep 15, 2023

   Member

   More actions

   I do not think is that code u have to check, is the specific line, the safe_issubclass method should not be touched I think
7. punndcoder28 commented on Sep 16, 2023

   

   punndcoder28

   on Sep 16, 2023

   Contributor

   More actions

   Checked the implementation of classes DocList and AnyDocArray and noticed that

   docarray/docarray/array/doc_list/doc_list.py

   Line 338 in d0b9990

   if isinstance(item, type) and safe_issubclass(item, BaseDoc):

   
   the above line fails when we do

   from docarray import DocList, BaseDoc
   
   doc = DocList[BaseDoc()]
   

   and the control goes to
   

   docarray/docarray/array/doc_list/doc_list.py

   Line 341 in d0b9990

   return super().__class_getitem__(item)

   
   but does not end up in the class AnyDocArray so we can handle this case in __class_getitem__ method of DocList by adding a condition to check
   if isinstance(item, object) and raise an exception of type ValueError
8. JoanFM commented on Sep 16, 2023

   

   JoanFM

   on Sep 16, 2023

   Member

   More actions

   Checked the implementation of classes DocList and AnyDocArray and noticed that

   docarray/docarray/array/doc_list/doc_list.py

   Line 338 in d0b9990

   if isinstance(item, type) and safe_issubclass(item, BaseDoc):

   the above line fails when we do

   from docarray import DocList, BaseDoc
   
   doc = DocList[BaseDoc()]
   

   and the control goes to

   docarray/docarray/array/doc_list/doc_list.py

   Line 341 in d0b9990

   return super().__class_getitem__(item)

   but does not end up in the class AnyDocArray so we can handle this case in __class_getitem__ method of DocList by adding a condition to check
   if isinstance(item, object) and raise an exception of type ValueError

   sounds reasonable

   👍React with 👍1Reacted by samsja
9. JoanFM

   linked a pull request that will close this issuefix: raise exception when type of DocList is object #1794on Sep 18, 2023
10. JoanFM

    closed this as completedin #1794on Sep 19, 2023
11. JoanFM commented on Sep 19, 2023

    

    JoanFM

    on Sep 19, 2023

    Member

    More actions

    The second part of the ticket remains valid, will open a new issue