[LINT] error 1540:

joce · joce · commit d3cde06ceae0 · 2010-11-19T20:34:14.000-07:00
Warning -- Pointer member 'Symbol' (Location) neither freed nor zero'ed by
destructor.

4 such warnings remain in the code for the following variables:
- ProcessExecute::m_hStdOutReadPipe
- ProcessExecute::m_hStdOutWritePipe
- ProcessExecute::m_hStdErrReadPipe
- ProcessExecute::m_hStdErrWritePipe

Dave is supposed to take care of these in a foreseeable future.

Signed-off-by: Jocelyn Legault &lt;jocelynlegault@gmail.com&gt;
diff --git a/PythonScript/src/AboutDialog2.cpp b/PythonScript/src/AboutDialog2.cpp
@@ -11,6 +11,11 @@ AboutDialog::AboutDialog(void)
 
 AboutDialog::~AboutDialog(void)
 {
+	if (m_hbrBackground)
+	{
+		DeleteObject(m_hbrBackground);
+		m_hbrBackground = NULL;
+	}
 }
 
 void AboutDialog::doDialog()
diff --git a/PythonScript/src/ConfigFile.cpp b/PythonScript/src/ConfigFile.cpp
@@ -34,6 +34,7 @@ ConfigFile::ConfigFile(const TCHAR *configDir, const TCHAR *pluginDir, HINSTANCE
 
 ConfigFile::~ConfigFile()
 {
+	m_hInst = NULL;
 	// TODO: Clean up 
 	// DeleteImage
 	// 
diff --git a/PythonScript/src/PromptDialog.cpp b/PythonScript/src/PromptDialog.cpp
@@ -15,13 +15,14 @@ PromptDialog::PromptDialog(HINSTANCE hInst, HWND hNotepad)
 {
 }
 
-
 PromptDialog::~PromptDialog()
 {
+	m_hInst = NULL;
+	m_hNotepad = NULL;
+	// m_hSelf is handed down to us and not created by us. Therefore, let's jsut NULL the variable.
+	m_hSelf = NULL;
 }
 
-
-
 PromptDialog::PROMPT_RESULT PromptDialog::prompt(const char *prompt, const char *title, const char *initial)
 {
 	m_result = RESULT_CANCEL;
@@ -34,8 +35,6 @@ PromptDialog::PROMPT_RESULT PromptDialog::prompt(const char *prompt, const char
 	return m_result;
 }
 
-
-
 BOOL CALLBACK PromptDialog::dlgProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
 {
 	switch(message)
@@ -58,7 +57,6 @@ BOOL CALLBACK PromptDialog::dlgProc(HWND hWnd, UINT message, WPARAM wParam, LPAR
 	}
 }
 
-
 BOOL CALLBACK PromptDialog::runDlgProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM /* lParam */)
 {
 	switch(message)
diff --git a/PythonScript/src/PromptDialog.h b/PythonScript/src/PromptDialog.h
@@ -35,7 +35,6 @@ class PromptDialog
 	std::string m_title;
 	std::string m_initial;
 	HWND m_hSelf;
-
 };
 
 #endif
diff --git a/PythonScript/src/ScintillaWrapper.cpp b/PythonScript/src/ScintillaWrapper.cpp
@@ -11,9 +11,7 @@ using namespace boost::python;
 
 ScintillaWrapper::ScintillaWrapper(const HWND handle)
 	: PyProducerConsumer<CallbackExecArgs*>(),
-	  m_handle(handle),
-	  m_tempString(NULL),
-	  m_tempStringLength(0)
+	  m_handle(handle)
 {
 }
 
@@ -30,6 +28,8 @@ void translateOutOfBounds(out_of_bounds_exception const& /* e */)
 
 ScintillaWrapper::~ScintillaWrapper()
 {
+	// m_handle isn't allocated here. Let's just NULL out reference to it, then.
+	m_handle = NULL;
 }
 /*
 void ScintillaWrapper::addText(str s)
diff --git a/PythonScript/src/ScintillaWrapper.h b/PythonScript/src/ScintillaWrapper.h
@@ -2561,10 +2561,6 @@ class ScintillaWrapper : public NppPythonScript::PyProducerConsumer<CallbackExec
 	// Active Scintilla handle
 	HWND m_handle;
 	
-	// Temporary buffer for returned strings
-	int m_tempStringLength;
-	char * m_tempString;
-
 	// Callbacks
 	
 	callbackT m_callbacks;

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,11 @@ AboutDialog::AboutDialog(void)`
`11`	`11`
`12`	`12`	`AboutDialog::~AboutDialog(void)`
`13`	`13`	`{`
	`14`	`+ if (m_hbrBackground)`
	`15`	`+ {`
	`16`	`+ DeleteObject(m_hbrBackground);`
	`17`	`+ m_hbrBackground = NULL;`
	`18`	`+ }`
`14`	`19`	`}`
`15`	`20`
`16`	`21`	`void AboutDialog::doDialog()`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ ConfigFile::ConfigFile(const TCHAR configDir, const TCHAR pluginDir, HINSTANCE`
`34`	`34`
`35`	`35`	`ConfigFile::~ConfigFile()`
`36`	`36`	`{`
	`37`	`+ m_hInst = NULL;`
`37`	`38`	`// TODO: Clean up`
`38`	`39`	`// DeleteImage`
`39`	`40`	`//`
Original file line number	Diff line number	Diff line change
`@@ -15,13 +15,14 @@ PromptDialog::PromptDialog(HINSTANCE hInst, HWND hNotepad)`
`15`	`15`	`{`
`16`	`16`	`}`
`17`	`17`
`18`		`-`
`19`	`18`	`PromptDialog::~PromptDialog()`
`20`	`19`	`{`
	`20`	`+ m_hInst = NULL;`
	`21`	`+ m_hNotepad = NULL;`
	`22`	`+ // m_hSelf is handed down to us and not created by us. Therefore, let's jsut NULL the variable.`
	`23`	`+ m_hSelf = NULL;`
`21`	`24`	`}`
`22`	`25`
`23`		`-`
`24`		`-`
`25`	`26`	`PromptDialog::PROMPT_RESULT PromptDialog::prompt(const char prompt, const char title, const char *initial)`
`26`	`27`	`{`
`27`	`28`	`m_result = RESULT_CANCEL;`
`@@ -34,8 +35,6 @@ PromptDialog::PROMPT_RESULT PromptDialog::prompt(const char *prompt, const char`
`34`	`35`	`return m_result;`
`35`	`36`	`}`
`36`	`37`
`37`		`-`
`38`		`-`
`39`	`38`	`BOOL CALLBACK PromptDialog::dlgProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)`
`40`	`39`	`{`
`41`	`40`	`switch(message)`
`@@ -58,7 +57,6 @@ BOOL CALLBACK PromptDialog::dlgProc(HWND hWnd, UINT message, WPARAM wParam, LPAR`
`58`	`57`	`}`
`59`	`58`	`}`
`60`	`59`
`61`		`-`
`62`	`60`	`BOOL CALLBACK PromptDialog::runDlgProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM /* lParam */)`
`63`	`61`	`{`
`64`	`62`	`switch(message)`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,7 @@ using namespace boost::python;`
`11`	`11`
`12`	`12`	`ScintillaWrapper::ScintillaWrapper(const HWND handle)`
`13`	`13`	`: PyProducerConsumer<CallbackExecArgs*>(),`
`14`		`- m_handle(handle),`
`15`		`- m_tempString(NULL),`
`16`		`- m_tempStringLength(0)`
	`14`	`+ m_handle(handle)`
`17`	`15`	`{`
`18`	`16`	`}`
`19`	`17`
`@@ -30,6 +28,8 @@ void translateOutOfBounds(out_of_bounds_exception const& /* e */)`
`30`	`28`
`31`	`29`	`ScintillaWrapper::~ScintillaWrapper()`
`32`	`30`	`{`
	`31`	`+ // m_handle isn't allocated here. Let's just NULL out reference to it, then.`
	`32`	`+ m_handle = NULL;`
`33`	`33`	`}`
`34`	`34`	`/*`
`35`	`35`	`void ScintillaWrapper::addText(str s)`