Added an option to create a mountpoint with a missing directory (cryfs#354)

jeremymeadows · web-flow · commit 353f287bdea1 · 2020-07-31T18:08:19.000-07:00
* Added an option to create a mountpoint with a missing directory

It skips the normal confirmation message, which makes cryfs easier
to use in scripts, or can be aliased for quicker use.

* separated basedir and mountpoint autocreate flags, and added tests

* Werror and clang-tidy fixes
added to the ChangeLog

* fixed the bugs that clang-tidy caused

never used clang before, so I don't really know what it did and why it
caused compile errors
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -17,6 +17,7 @@ New features:
   Noatime reduces the amount of write necessary and with that reduces the probability for synchronization conflicts
   or corrupted file systems if a power outage happens while writing.
 * Add an --immediate flag to cryfs-unmount that tries to unmount immediately and doesn't wait for processes to release their locks on the file system.
+* Add a --create-missing-basedir and --create-missing-mountpoint flag to create the base directory and mount directory respectively, if they don't exist, skipping the confirmation prompt.
 
 
 Version 0.10.3 (unreleased)
diff --git a/doc/man/cryfs.1 b/doc/man/cryfs.1
@@ -180,6 +180,18 @@ By default, CryFS remembers file systems it has seen in this base directory and
 .
 .
 .TP
+\fB\-\-create-missing-basedir\fI
+.
+Creates the base directory even if there is no directory currently there, skipping the normal confirmation message to create it later.
+.
+.
+.TP
+\fB\-\-create-missing-mountpoint\fI
+.
+Creates the mountpoint even if there is no directory currently there, skipping the normal confirmation message to create it later.
+.
+.
+.TP
 \fB\-\-missing-block-is-integrity-violation\fR=true
 .
 When CryFS encounters a missing ciphertext block, it cannot cannot (yet) know if it was deleted by an unauthorized adversary or by a second authorized client. This is one of the restrictions of the integrity checks currently in place. You can enable this flag to treat missing ciphertext blocks as integrity violations, but then your file system will not be usable by multiple clients anymore. By default, this flag is disabled.
diff --git a/src/blockstore/implementations/compressing/compressors/RunLengthEncoding.cpp b/src/blockstore/implementations/compressing/compressors/RunLengthEncoding.cpp
@@ -114,7 +114,7 @@ namespace blockstore {
         }
 
         void RunLengthEncoding::_decodeArbitraryWords(istringstream *stream, ostringstream *decompressed) {
-            uint16_t size;
+            uint16_t size = 0;
             stream->read(reinterpret_cast<char*>(&size), sizeof(uint16_t));
             ASSERT(stream->good(), "Premature end of stream");
             Data run(size);
@@ -124,10 +124,10 @@ namespace blockstore {
         }
 
         void RunLengthEncoding::_decodeIdenticalWords(istringstream *stream, ostringstream *decompressed) {
-            uint16_t size;
+            uint16_t size = 0;
             stream->read(reinterpret_cast<char*>(&size), sizeof(uint16_t));
             ASSERT(stream->good(), "Premature end of stream");
-            uint8_t value;
+            uint8_t value = 0;
             stream->read(reinterpret_cast<char*>(&value), 1);
             ASSERT(stream->good(), "Premature end of stream");
             Data run(size);
diff --git a/src/cryfs-cli/Cli.cpp b/src/cryfs-cli/Cli.cpp
@@ -347,10 +347,10 @@ namespace cryfs_cli {
     }
 
 	void Cli::_sanityChecks(const ProgramOptions &options) {
-		_checkDirAccessible(bf::absolute(options.baseDir()), "base directory", ErrorCode::InaccessibleBaseDir);
+		_checkDirAccessible(bf::absolute(options.baseDir()), "base directory", options.createMissingBasedir(), ErrorCode::InaccessibleBaseDir);
 
 		if (!options.mountDirIsDriveLetter()) {
-			_checkDirAccessible(options.mountDir(), "mount directory", ErrorCode::InaccessibleMountDir);
+			_checkDirAccessible(options.mountDir(), "mount directory", options.createMissingMountpoint(), ErrorCode::InaccessibleMountDir);
 			_checkMountdirDoesntContainBasedir(options);
 		} else {
 			if (bf::exists(options.mountDir())) {
@@ -359,9 +359,14 @@ namespace cryfs_cli {
 		}
     }
 
-    void Cli::_checkDirAccessible(const bf::path &dir, const std::string &name, ErrorCode errorCode) {
+    void Cli::_checkDirAccessible(const bf::path &dir, const std::string &name, bool createMissingDir, ErrorCode errorCode) {
         if (!bf::exists(dir)) {
-            bool create = _console->askYesNo("Could not find " + name + ". Do you want to create it?", false);
+            bool create = createMissingDir;
+            if (create) {
+                LOG(INFO, "Automatically creating {}", name);
+            } else {
+                create = _console->askYesNo("Could not find " + name + ". Do you want to create it?", false);
+            }
             if (create) {
                 if (!bf::create_directory(dir)) {
                     throw CryfsException("Error creating "+name, errorCode);
diff --git a/src/cryfs-cli/Cli.h b/src/cryfs-cli/Cli.h
@@ -37,7 +37,7 @@ namespace cryfs_cli {
         void _sanityChecks(const program_options::ProgramOptions &options);
         void _checkMountdirDoesntContainBasedir(const program_options::ProgramOptions &options);
         bool _pathContains(const boost::filesystem::path &parent, const boost::filesystem::path &child);
-        void _checkDirAccessible(const boost::filesystem::path &dir, const std::string &name, cryfs::ErrorCode errorCode);
+        void _checkDirAccessible(const boost::filesystem::path &dir, const std::string &name, bool createMissingDir, cryfs::ErrorCode errorCode);
         std::shared_ptr<cpputils::TempFile> _checkDirWriteable(const boost::filesystem::path &dir, const std::string &name, cryfs::ErrorCode errorCode);
         void _checkDirReadable(const boost::filesystem::path &dir, std::shared_ptr<cpputils::TempFile> tempfile, const std::string &name, cryfs::ErrorCode errorCode);
         boost::optional<cpputils::unique_ref<CallAfterTimeout>> _createIdleCallback(boost::optional<double> minutes, std::function<void()> callback);
diff --git a/src/cryfs-cli/program_options/Parser.cpp b/src/cryfs-cli/program_options/Parser.cpp
@@ -58,6 +58,8 @@ ProgramOptions Parser::parse(const vector<string> &supportedCiphers) const {
     bool foreground = vm.count("foreground");
     bool allowFilesystemUpgrade = vm.count("allow-filesystem-upgrade");
     bool allowReplacedFilesystem = vm.count("allow-replaced-filesystem");
+    bool createMissingBasedir = vm.count("create-missing-basedir");
+    bool createMissingMountpoint = vm.count("create-missing-mountpoint");
     optional<double> unmountAfterIdleMinutes = 0.0;  // first setting to 0 and then to none is somehow needed to silence a GCC warning from -Wmaybe-uninitialized
     unmountAfterIdleMinutes = none;
     if (vm.count("unmount-idle")) {
@@ -90,7 +92,7 @@ ProgramOptions Parser::parse(const vector<string> &supportedCiphers) const {
         }
     }
 
-    return ProgramOptions(std::move(baseDir), std::move(mountDir), std::move(configfile), foreground, allowFilesystemUpgrade, allowReplacedFilesystem, std::move(unmountAfterIdleMinutes), std::move(logfile), std::move(cipher), blocksizeBytes, allowIntegrityViolations, std::move(missingBlockIsIntegrityViolation), std::move(fuseOptions));
+    return ProgramOptions(std::move(baseDir), std::move(mountDir), std::move(configfile), foreground, allowFilesystemUpgrade, allowReplacedFilesystem, createMissingBasedir, createMissingMountpoint, std::move(unmountAfterIdleMinutes), std::move(logfile), std::move(cipher), blocksizeBytes, allowIntegrityViolations, std::move(missingBlockIsIntegrityViolation), std::move(fuseOptions));
 }
 
 void Parser::_checkValidCipher(const string &cipher, const vector<string> &supportedCiphers) {
@@ -165,6 +167,8 @@ void Parser::_addAllowedOptions(po::options_description *desc) {
             ("allow-integrity-violations", "Disable integrity checks. Integrity checks ensure that your file system was not manipulated or rolled back to an earlier version. Disabling them is needed if you want to load an old snapshot of your file system.")
             ("allow-filesystem-upgrade", "Allow upgrading the file system if it was created with an old CryFS version. After the upgrade, older CryFS versions might not be able to use the file system anymore.")
             ("allow-replaced-filesystem", "By default, CryFS remembers file systems it has seen in this base directory and checks that it didn't get replaced by an attacker with an entirely different file system since the last time it was loaded. However, if you do want to replace the file system with an entirely new one, you can pass in this option to disable the check.")
+            ("create-missing-basedir", "Creates the base directory even if there is no directory currently there, skipping the normal confirmation message to create it later.")
+            ("create-missing-mountpoint", "Creates the mountpoint even if there is no directory currently there, skipping the normal confirmation message to create it later.")
             ("show-ciphers", "Show list of supported ciphers.")
             ("unmount-idle", po::value<double>(), "Automatically unmount after specified number of idle minutes.")
             ("logfile", po::value<string>(), "Specify the file to write log messages to. If this is not specified, log messages will go to stdout, or syslog if CryFS is running in the background.")
diff --git a/src/cryfs-cli/program_options/ProgramOptions.cpp b/src/cryfs-cli/program_options/ProgramOptions.cpp
@@ -10,19 +10,24 @@ using boost::optional;
 namespace bf = boost::filesystem;
 
 ProgramOptions::ProgramOptions(bf::path baseDir, bf::path mountDir, optional<bf::path> configFile,
-                               bool foreground, bool allowFilesystemUpgrade, bool allowReplacedFilesystem, optional<double> unmountAfterIdleMinutes,
+                               bool foreground, bool allowFilesystemUpgrade, bool allowReplacedFilesystem, 
+                               bool createMissingBasedir, bool createMissingMountpoint,
+                               optional<double> unmountAfterIdleMinutes,
                                optional<bf::path> logFile, optional<string> cipher,
                                optional<uint32_t> blocksizeBytes,
                                bool allowIntegrityViolations,
                                boost::optional<bool> missingBlockIsIntegrityViolation,
                                vector<string> fuseOptions)
-    : _configFile(std::move(configFile)), _baseDir(bf::absolute(std::move(baseDir))), _mountDir(std::move(mountDir)),
-      _mountDirIsDriveLetter(cpputils::path_is_just_drive_letter(_mountDir)),
+    : _baseDir(bf::absolute(std::move(baseDir))), _mountDir(std::move(mountDir)), _configFile(std::move(configFile)),
 	  _foreground(foreground),
-	  _allowFilesystemUpgrade(allowFilesystemUpgrade), _allowReplacedFilesystem(allowReplacedFilesystem), _allowIntegrityViolations(allowIntegrityViolations),
-      _cipher(std::move(cipher)), _blocksizeBytes(std::move(blocksizeBytes)), _unmountAfterIdleMinutes(std::move(unmountAfterIdleMinutes)),
-      _missingBlockIsIntegrityViolation(std::move(missingBlockIsIntegrityViolation)), _logFile(std::move(logFile)),
-      _fuseOptions(std::move(fuseOptions)) {
+	  _allowFilesystemUpgrade(allowFilesystemUpgrade), _allowReplacedFilesystem(allowReplacedFilesystem),
+      _createMissingBasedir(createMissingBasedir), _createMissingMountpoint(createMissingMountpoint),
+      _unmountAfterIdleMinutes(std::move(unmountAfterIdleMinutes)), _logFile(std::move(logFile)),
+      _cipher(std::move(cipher)), _blocksizeBytes(std::move(blocksizeBytes)),
+      _allowIntegrityViolations(allowIntegrityViolations),
+      _missingBlockIsIntegrityViolation(std::move(missingBlockIsIntegrityViolation)),
+      _fuseOptions(std::move(fuseOptions)),
+      _mountDirIsDriveLetter(cpputils::path_is_just_drive_letter(_mountDir)) {
 	if (!_mountDirIsDriveLetter) {
 		_mountDir = bf::absolute(std::move(_mountDir));
 	}
@@ -52,6 +57,14 @@ bool ProgramOptions::allowFilesystemUpgrade() const {
   return _allowFilesystemUpgrade;
 }
 
+bool ProgramOptions::createMissingBasedir() const {
+    return _createMissingBasedir;
+}
+
+bool ProgramOptions::createMissingMountpoint() const {
+    return _createMissingMountpoint;
+}
+
 const optional<double> &ProgramOptions::unmountAfterIdleMinutes() const {
     return _unmountAfterIdleMinutes;
 }
diff --git a/src/cryfs-cli/program_options/ProgramOptions.h b/src/cryfs-cli/program_options/ProgramOptions.h
@@ -14,7 +14,9 @@ namespace cryfs_cli {
         public:
             ProgramOptions(boost::filesystem::path baseDir, boost::filesystem::path mountDir,
                            boost::optional<boost::filesystem::path> configFile,
-                           bool foreground, bool allowFilesystemUpgrade, bool allowReplacedFilesystem, boost::optional<double> unmountAfterIdleMinutes,
+                           bool foreground, bool allowFilesystemUpgrade, bool allowReplacedFilesystem,
+                           bool createMissingBasedir, bool createMissingMountpoint,
+                           boost::optional<double> unmountAfterIdleMinutes,
                            boost::optional<boost::filesystem::path> logFile,
                            boost::optional<std::string> cipher,
                            boost::optional<uint32_t> blocksizeBytes,
@@ -25,34 +27,38 @@ namespace cryfs_cli {
 
             const boost::filesystem::path &baseDir() const;
             const boost::filesystem::path &mountDir() const;
-			bool mountDirIsDriveLetter() const;
             const boost::optional<boost::filesystem::path> &configFile() const;
             bool foreground() const;
             bool allowFilesystemUpgrade() const;
             bool allowReplacedFilesystem() const;
+            bool createMissingBasedir() const;
+            bool createMissingMountpoint() const;
+            const boost::optional<double> &unmountAfterIdleMinutes() const;
+            const boost::optional<boost::filesystem::path> &logFile() const;
             const boost::optional<std::string> &cipher() const;
             const boost::optional<uint32_t> &blocksizeBytes() const;
-            const boost::optional<double> &unmountAfterIdleMinutes() const;
             bool allowIntegrityViolations() const;
             const boost::optional<bool> &missingBlockIsIntegrityViolation() const;
-            const boost::optional<boost::filesystem::path> &logFile() const;
             const std::vector<std::string> &fuseOptions() const;
+			bool mountDirIsDriveLetter() const;
 
         private:
-			boost::optional<boost::filesystem::path> _configFile;
             boost::filesystem::path _baseDir; // this is always absolute
             boost::filesystem::path _mountDir; // this is absolute iff !_mountDirIsDriveLetter
-			bool _mountDirIsDriveLetter;
+			boost::optional<boost::filesystem::path> _configFile;
             bool _foreground;
             bool _allowFilesystemUpgrade;
             bool _allowReplacedFilesystem;
-            bool _allowIntegrityViolations;
+            bool _createMissingBasedir;
+            bool _createMissingMountpoint;
+            boost::optional<double> _unmountAfterIdleMinutes;
+            boost::optional<boost::filesystem::path> _logFile;
             boost::optional<std::string> _cipher;
             boost::optional<uint32_t> _blocksizeBytes;
-            boost::optional<double> _unmountAfterIdleMinutes;
+            bool _allowIntegrityViolations;
             boost::optional<bool> _missingBlockIsIntegrityViolation;
-            boost::optional<boost::filesystem::path> _logFile;
             std::vector<std::string> _fuseOptions;
+			bool _mountDirIsDriveLetter;
 
             DISALLOW_COPY_AND_ASSIGN(ProgramOptions);
         };
diff --git a/src/cryfs/impl/filesystem/fsblobstore/FsBlobView.h b/src/cryfs/impl/filesystem/fsblobstore/FsBlobView.h
@@ -95,7 +95,7 @@ namespace cryfs {
 
         static uint16_t getFormatVersionHeader(const blobstore::Blob &blob) {
             static_assert(sizeof(uint16_t) == sizeof(FORMAT_VERSION_HEADER), "Wrong type used to read format version header");
-            uint16_t actualFormatVersion;
+            uint16_t actualFormatVersion = 0;
             blob.read(&actualFormatVersion, 0, sizeof(FORMAT_VERSION_HEADER));
             return actualFormatVersion;
         }
@@ -116,7 +116,7 @@ namespace cryfs {
         }
 
         static BlobType _blobType(const blobstore::Blob &blob) {
-            uint8_t result;
+            uint8_t result = 0;
             blob.read(&result, sizeof(FORMAT_VERSION_HEADER), sizeof(uint8_t));
             return static_cast<BlobType>(result);
         }
diff --git a/src/cryfs/impl/localstate/LocalStateMetadata.cpp b/src/cryfs/impl/localstate/LocalStateMetadata.cpp
@@ -58,7 +58,7 @@ void LocalStateMetadata::_save(const bf::path &metadataFilePath) const {
 
 namespace {
 uint32_t _generateClientId() {
-  uint32_t result;
+  uint32_t result = 0;
   do {
     result = cpputils::deserialize<uint32_t>(Random::PseudoRandom().getFixedSize<sizeof(uint32_t)>().data());
   } while(result == KnownBlockVersions::CLIENT_ID_FOR_DELETED_BLOCK); // Safety check - CLIENT_ID_FOR_DELETED_BLOCK shouldn't be used by any valid client.
@@ -73,7 +73,7 @@ optional<uint32_t> _tryLoadClientIdFromLegacyFile(const bf::path &metadataFilePa
     return none;
   }
 
-  uint32_t value;
+  uint32_t value = 0;
   file >> value;
   file.close();
   bf::remove(myClientIdFile);
diff --git a/test/blobstore/implementations/onblocks/BlobSizeTest.cpp b/test/blobstore/implementations/onblocks/BlobSizeTest.cpp
@@ -79,34 +79,34 @@ TEST_F(BlobSizeTest, BlobSizeStaysIntactWhenLoading) {
 }
 
 TEST_F(BlobSizeTest, WritingAtEndOfBlobGrowsBlob_Empty) {
-  int value;
+  int value = 0;
   blob->write(&value, 0, 4);
   EXPECT_EQ(4u, blob->size());
 }
 
 TEST_F(BlobSizeTest, WritingAfterEndOfBlobGrowsBlob_Empty) {
-  int value;
+  int value = 0;
   blob->write(&value, 2, 4);
   EXPECT_EQ(6u, blob->size());
 }
 
 TEST_F(BlobSizeTest, WritingOverEndOfBlobGrowsBlob_NonEmpty) {
   blob->resize(1);
-  int value;
+  int value = 0;
   blob->write(&value, 0, 4);
   EXPECT_EQ(4u, blob->size());
 }
 
 TEST_F(BlobSizeTest, WritingAtEndOfBlobGrowsBlob_NonEmpty) {
   blob->resize(1);
-  int value;
+  int value = 0;
   blob->write(&value, 1, 4);
   EXPECT_EQ(5u, blob->size());
 }
 
 TEST_F(BlobSizeTest, WritingAfterEndOfBlobGrowsBlob_NonEmpty) {
   blob->resize(1);
-  int value;
+  int value = 0;
   blob->write(&value, 2, 4);
   EXPECT_EQ(6u, blob->size());
 }
diff --git a/test/cpp-utils/io/ConsoleTest.h b/test/cpp-utils/io/ConsoleTest.h
@@ -50,7 +50,7 @@ class ConsoleTest: public ::testing::Test {
         std::getline(_output, actual, delimiter);
         EXPECT_EQ(expected, actual);
         for (char expected_char : expected_after_delimiter) {
-            char actual_char;
+            char actual_char = 0;
             _output.get(actual_char);
             EXPECT_EQ(expected_char, actual_char);
         }
diff --git a/test/cryfs-cli/CliTest_Setup.cpp b/test/cryfs-cli/CliTest_Setup.cpp
@@ -1,6 +1,7 @@
 #include "testutils/CliTest.h"
 
 using cpputils::TempFile;
+using cryfs::ErrorCode;
 
 namespace bf = boost::filesystem;
 
@@ -34,6 +35,42 @@ TEST_F(CliTest_Setup, ConfigfileGiven) {
     EXPECT_RUN_SUCCESS({basedir.string().c_str(), mountdir.string().c_str(), "-f", "--cipher", "aes-256-gcm", "--config", configfile.path().string().c_str()}, mountdir);
 }
 
+TEST_F(CliTest_Setup, AutocreateBasedir) {
+    TempFile notexisting_basedir(false);
+    //Specify --cipher parameter to make it non-interactive
+    //TODO Remove "-f" parameter, once EXPECT_RUN_SUCCESS can handle that
+    EXPECT_RUN_SUCCESS({notexisting_basedir.path().string().c_str(), mountdir.string().c_str(), "-f", "--cipher", "aes-256-gcm", "--create-missing-basedir"}, mountdir);
+}
+
+TEST_F(CliTest_Setup, AutocreateBasedirFail) {
+    TempFile notexisting_basedir(false);
+    //Specify --cipher parameter to make it non-interactive
+    //TODO Remove "-f" parameter, once EXPECT_RUN_SUCCESS can handle that
+    EXPECT_RUN_ERROR(
+            {notexisting_basedir.path().string().c_str(), mountdir.string().c_str(), "-f", "--cipher", "aes-256-gcm"},
+            "Error 16: base directory not found.",
+            ErrorCode::InaccessibleBaseDir
+    );
+}
+
+TEST_F(CliTest_Setup, AutocreateMountpoint) {
+    TempFile notexisting_mountpoint(false);
+    //Specify --cipher parameter to make it non-interactive
+    //TODO Remove "-f" parameter, once EXPECT_RUN_SUCCESS can handle that
+    EXPECT_RUN_SUCCESS({basedir.string().c_str(), notexisting_mountpoint.path().string().c_str(), "-f", "--cipher", "aes-256-gcm", "--create-missing-mountpoint"}, notexisting_mountpoint.path());
+}
+
+TEST_F(CliTest_Setup, AutocreateMountdirFail) {
+    TempFile notexisting_mountdir(false);
+    //Specify --cipher parameter to make it non-interactive
+    //TODO Remove "-f" parameter, once EXPECT_RUN_SUCCESS can handle that
+    EXPECT_RUN_ERROR(
+            {basedir.string().c_str(), notexisting_mountdir.path().string().c_str(), "-f", "--cipher", "aes-256-gcm"},
+            "Error 17: mount directory not found.",
+            ErrorCode::InaccessibleMountDir
+    );
+}
+
 TEST_F(CliTest_Setup, FuseOptionGiven) {
     //Specify --cipher parameter to make it non-interactive
     //TODO Remove "-f" parameter, once EXPECT_RUN_SUCCESS can handle that
diff --git a/test/cryfs-cli/program_options/ParserTest.cpp b/test/cryfs-cli/program_options/ParserTest.cpp
diff --git a/test/cryfs-cli/program_options/ProgramOptionsTest.cpp b/test/cryfs-cli/program_options/ProgramOptionsTest.cpp
diff --git a/test/fspp/fuse/createAndOpenFile/FuseCreateAndOpenFileDescriptorTest.cpp b/test/fspp/fuse/createAndOpenFile/FuseCreateAndOpenFileDescriptorTest.cpp
diff --git a/test/fspp/fuse/openFile/FuseOpenFileDescriptorTest.cpp b/test/fspp/fuse/openFile/FuseOpenFileDescriptorTest.cpp

Original file line number	Diff line number	Diff line change
`@@ -180,6 +180,18 @@ By default, CryFS remembers file systems it has seen in this base directory and`
`180`	`180`	`.`
`181`	`181`	`.`
`182`	`182`	`.TP`
	`183`	`+\fB\-\-create-missing-basedir\fI`
	`184`	`+.`
	`185`	`+Creates the base directory even if there is no directory currently there, skipping the normal confirmation message to create it later.`
	`186`	`+.`
	`187`	`+.`
	`188`	`+.TP`
	`189`	`+\fB\-\-create-missing-mountpoint\fI`
	`190`	`+.`
	`191`	`+Creates the mountpoint even if there is no directory currently there, skipping the normal confirmation message to create it later.`
	`192`	`+.`
	`193`	`+.`
	`194`	`+.TP`
`183`	`195`	`\fB\-\-missing-block-is-integrity-violation\fR=true`
`184`	`196`	`.`
`185`	`197`	`When CryFS encounters a missing ciphertext block, it cannot cannot (yet) know if it was deleted by an unauthorized adversary or by a second authorized client. This is one of the restrictions of the integrity checks currently in place. You can enable this flag to treat missing ciphertext blocks as integrity violations, but then your file system will not be usable by multiple clients anymore. By default, this flag is disabled.`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ namespace cryfs {`
`95`	`95`
`96`	`96`	`static uint16_t getFormatVersionHeader(const blobstore::Blob &blob) {`
`97`	`97`	`static_assert(sizeof(uint16_t) == sizeof(FORMAT_VERSION_HEADER), "Wrong type used to read format version header");`
`98`		`- uint16_t actualFormatVersion;`
	`98`	`+ uint16_t actualFormatVersion = 0;`
`99`	`99`	`blob.read(&actualFormatVersion, 0, sizeof(FORMAT_VERSION_HEADER));`
`100`	`100`	`return actualFormatVersion;`
`101`	`101`	`}`
`@@ -116,7 +116,7 @@ namespace cryfs {`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`static BlobType _blobType(const blobstore::Blob &blob) {`
`119`		`- uint8_t result;`
	`119`	`+ uint8_t result = 0;`
`120`	`120`	`blob.read(&result, sizeof(FORMAT_VERSION_HEADER), sizeof(uint8_t));`
`121`	`121`	`return static_cast<BlobType>(result);`
`122`	`122`	`}`