smartstore#971 Product is added to cart automatically if it has a non-required file upload attribute

mgesing · mgesing · commit a947a44dc4fc · 2016-05-27T18:28:15.000+02:00
diff --git a/changelog.md b/changelog.md
@@ -46,6 +46,7 @@
 * Download nor sample download were removable when editing product
 * Copied product must not share sample download of source product. Could produce "The DELETE statement conflicted with the REFERENCE constraint 'FK_dbo.Product_dbo.Download_SampleDownloadId'".
 * #921 Specification attribute options with single quotation marks are causing a Javascript error
+* #971 Product is added to cart automatically if it has a non-required file upload attribute
 
 
 ## SmartStore.NET 2.5
diff --git a/src/Presentation/SmartStore.Web/Scripts/public.product-detail.js b/src/Presentation/SmartStore.Web/Scripts/public.product-detail.js
@@ -25,15 +25,25 @@
 
 			// update product data and gallery
 		    $(el).find(':input').change(function () {
+		    	var inputType = $(this).attr('type');
+		    	if (inputType && (inputType === 'file' || inputType === 'submit'))
+		    		return this;
+
 		    	var context = $(this).closest('.update-container');
 
-		    	if (context[0]) {		// associated or bundled item
+		    	if (context[0]) {
 		    	}
 		    	else {
 		    		context = el;
 		    	}
 
-		    	context.doAjax({
+		    	var url = context.attr('data-url');
+		    	if (!url) {
+		    		return this;
+		    	}
+
+		    	$({}).doAjax({
+		    		url: url,
 		    		data: context.find(':input').serialize(),
 		    		callbackSuccess: function (response) {
 		    			self.updateDetailData(response, context);
diff --git a/src/Presentation/SmartStore.Web/Scripts/public.product-detail.mobile.js b/src/Presentation/SmartStore.Web/Scripts/public.product-detail.mobile.js
@@ -16,17 +16,27 @@
 			
 			var opts = this.options;
 			
-			// update product data and gallery
-		    $(el).find(':input').change(function () {
+			// update product data. grouped product not supported because associated product has no mobile view.
+			$(el).find(':input').change(function () {
+				var inputType = $(this).attr('type');
+				if (inputType && (inputType === 'file' || inputType === 'submit'))
+					return this;
+
 		    	var context = $(this).closest('.update-container');
 
-		    	if (context[0]) {		// associated or bundled item
+		    	if (context[0]) {
 		    	}
 		    	else {
 		    		context = el;
 		    	}
 
-		    	context.doAjax({
+		    	var url = context.attr('data-url');
+		    	if (!url) {
+		    		return this;
+		    	}
+
+		    	$({}).doAjax({
+		    		url: url,
 		    		data: context.find(':input').serialize(),
 		    		callbackSuccess: function (response) {
 		    			self.updateDetailData(response, context);
diff --git a/src/Presentation/SmartStore.Web/Views/Product/ProductTemplate.Simple.Mobile.cshtml b/src/Presentation/SmartStore.Web/Views/Product/ProductTemplate.Simple.Mobile.cshtml
@@ -60,7 +60,7 @@
 	}
 }
 
-<div class="page product-details-page update-container">
+<div class="page product-details-page update-container" data-url="@Html.Raw(Model.UpdateProductDetailsUrl())">
     <div class="page-body">
         @Html.Widget("mobile_productdetails_top")
         @*we add enctype = "multipart/form-data" because "File upload" attribute control type requries it*@

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`
`63`		`-<div class="page product-details-page update-container">`
	`63`	`+<div class="page product-details-page update-container" data-url="@Html.Raw(Model.UpdateProductDetailsUrl())">`
`64`	`64`	`<div class="page-body">`
`65`	`65`	`@Html.Widget("mobile_productdetails_top")`
`66`	`66`	`@we add enctype = "multipart/form-data" because "File upload" attribute control type requries it@`