SEO: Limited sitemap.xml caching to 2 hours

muratcakir · muratcakir · commit 1597eeca4ecc · 2014-12-04T19:19:55.000+01:00
diff --git a/src/Libraries/SmartStore.Services/Seo/BaseSitemapGenerator.cs b/src/Libraries/SmartStore.Services/Seo/BaseSitemapGenerator.cs
@@ -4,6 +4,7 @@
 using System.Web.Mvc;
 using System.Xml;
 using SmartStore.Core;
+using SmartStore.Core.Data;
 
 namespace SmartStore.Services.Seo
 {
@@ -48,18 +49,21 @@ public string Generate(UrlHelper urlHelper)
 
         public void Generate(UrlHelper urlHelper, Stream stream)
         {
-            _writer = new XmlTextWriter(stream, Encoding.UTF8);
-            _writer.Formatting = Formatting.Indented;
-            _writer.WriteStartDocument();
-            _writer.WriteStartElement("urlset");
-            _writer.WriteAttributeString("xmlns", "http://www.sitemaps.org/schemas/sitemap/0.9");
-            _writer.WriteAttributeString("xmlns:xsi", "http://www.w3.org/2001/XMLSchema-instance");
-            _writer.WriteAttributeString("xsi:schemaLocation", "http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd");
+			using (var scope = new DbContextScope(autoDetectChanges: false, forceNoTracking: true))
+			{
+				_writer = new XmlTextWriter(stream, Encoding.UTF8);
+				_writer.Formatting = Formatting.Indented;
+				_writer.WriteStartDocument();
+				_writer.WriteStartElement("urlset");
+				_writer.WriteAttributeString("xmlns", "http://www.sitemaps.org/schemas/sitemap/0.9");
+				_writer.WriteAttributeString("xmlns:xsi", "http://www.w3.org/2001/XMLSchema-instance");
+				_writer.WriteAttributeString("xsi:schemaLocation", "http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd");
 
-			GenerateUrlNodes(urlHelper);
+				GenerateUrlNodes(urlHelper);
 
-            _writer.WriteEndElement();
-            _writer.Close();
+				_writer.WriteEndElement();
+				_writer.Close();
+			}
         }
 
         #endregion
diff --git a/src/Presentation/SmartStore.Web/Controllers/HomeController.cs b/src/Presentation/SmartStore.Web/Controllers/HomeController.cs
@@ -207,7 +207,7 @@ public ActionResult SitemapSeo()
 			var sitemap = _services.Cache.Get(cacheKey, () =>
 			{
 				return _sitemapGenerator.Value.Generate(this.Url);
-			});
+			}, 120);
 
 			return Content(sitemap, "text/xml");
 		}

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ public ActionResult SitemapSeo()`
`207`	`207`	`var sitemap = _services.Cache.Get(cacheKey, () =>`
`208`	`208`	`{`
`209`	`209`	`return _sitemapGenerator.Value.Generate(this.Url);`
`210`		`- });`
	`210`	`+ }, 120);`
`211`	`211`
`212`	`212`	`return Content(sitemap, "text/xml");`
`213`	`213`	`}`