remove interface that was only used a single time

benfry · benfry · commit 81b1f35cc73e · 2015-01-25T13:12:09.000-05:00
diff --git a/java/src/processing/mode/java/DebugTray.java b/java/src/processing/mode/java/DebugTray.java
@@ -80,6 +80,8 @@ public class DebugTray extends JFrame {
   /// processing / "advanced" mode flag (currently not used)
   protected boolean p5mode = true; 
 
+  // The tray will be placed at this amount from the top of the editor window,
+  // and extend to this amount from the bottom of the editor window.
   final int VERTICAL_OFFSET = 64;
     
   
diff --git a/java/src/processing/mode/java/debug/LineHighlight.java b/java/src/processing/mode/java/debug/LineHighlight.java
@@ -33,7 +33,7 @@
  *
  * @author Martin Leopold <m@martinleopold.com>
  */
-public class LineHighlight implements LineListener {
+public class LineHighlight {
 
   protected JavaEditor editor; // the view, used for highlighting lines by setting a background color
   protected Color bgColor; // the background color for highlighting lines
@@ -154,7 +154,6 @@ public boolean isOnLine(LineID testLine) {
      * @param oldLineIdx the old line index (0-based)
      * @param newLineIdx the new line index (0-based)
      */
-    @Override
     public void lineChanged(LineID line, int oldLineIdx, int newLineIdx) {
         // clear old line
         if (editor.isInCurrentTab(new LineID(line.fileName(), oldLineIdx))) {
diff --git a/java/src/processing/mode/java/debug/LineID.java b/java/src/processing/mode/java/debug/LineID.java
@@ -45,7 +45,7 @@ public class LineID implements DocumentListener {
     protected int lineIdx; // the line number, 0-based
     protected Document doc; // the Document to use for line number tracking
     protected Position pos; // the Position acquired during line number tracking
-    protected Set<LineListener> listeners = new HashSet<LineListener>(); // listeners for line number changes
+    protected Set<LineHighlight> listeners = new HashSet<LineHighlight>(); // listeners for line number changes
 
     public LineID(String fileName, int lineIdx) {
         this.fileName = fileName;
@@ -181,7 +181,7 @@ protected synchronized void updatePosition() {
             int oldLineIdx = lineIdx;
             lineIdx = doc.getDefaultRootElement().getElementIndex(offset); // offset to lineNo
             if (lineIdx != oldLineIdx) {
-                for (LineListener l : listeners) {
+                for (LineHighlight l : listeners) {
                     if (l != null) {
                         l.lineChanged(this, oldLineIdx, lineIdx);
                     } else {
@@ -197,7 +197,7 @@ protected synchronized void updatePosition() {
      *
      * @param l the listener to add
      */
-    public void addListener(LineListener l) {
+    public void addListener(LineHighlight l) {
         listeners.add(l);
     }
 
@@ -206,7 +206,7 @@ public void addListener(LineListener l) {
      *
      * @param l the listener to remove
      */
-    public void removeListener(LineListener l) {
+    public void removeListener(LineHighlight l) {
         listeners.remove(l);
     }
 
diff --git a/java/src/processing/mode/java/debug/LineListener.java b/java/src/processing/mode/java/debug/LineListener.java
diff --git a/todo.txt b/todo.txt
@@ -100,6 +100,8 @@ X     removed, seems to be duplicate/used the same way
 _ crashed on startup w/ JavaScript mode as default b/c PdeKeyListener not found
 _   because it's in the other ClassLoader, can no longer rely on it
 
+_ do the right thing on passing around List vs ArrayList and others
+
 gui
 _ need 'actively pressed' version of 'play' and 'stop'
 _   could do rollover as well, but do other apps use them?
