Small threading fixes for run/present/tweak

JakubValtar · JakubValtar · commit 4a50ea319bab · 2017-01-21T19:03:12.000+01:00
diff --git a/java/src/processing/mode/java/JavaEditor.java b/java/src/processing/mode/java/JavaEditor.java
@@ -1057,15 +1057,15 @@ public void handleRun() {
       debugger.continueDebug();
 
     } else {
+      prepareRun();
+      toolbar.activateRun();
       new Thread(new Runnable() {
         public void run() {
-          prepareRun();
           try {
-            toolbar.activateRun();
             //runtime = jmode.handleRun(sketch, JavaEditor.this);
             runtime = jmode.handleLaunch(sketch, JavaEditor.this, false);
           } catch (Exception e) {
-            statusError(e);
+            EventQueue.invokeLater(() -> statusError(e));
           }
         }
       }).start();
@@ -1074,31 +1074,39 @@ public void run() {
 
 
   public void handlePresent() {
+    prepareRun();
+    toolbar.activateRun();
     new Thread(new Runnable() {
       public void run() {
-        prepareRun();
         try {
-          toolbar.activateRun();
           //runtime = jmode.handlePresent(sketch, JavaEditor.this);
           runtime = jmode.handleLaunch(sketch, JavaEditor.this, true);
         } catch (Exception e) {
-          statusError(e);
+          EventQueue.invokeLater(() -> statusError(e));
         }
       }
     }).start();
   }
 
 
   public void handleTweak() {
+    prepareRun();
+    //toolbar.activate(JavaToolbar.RUN);
+    toolbar.activateRun();
+
+    if (sketch.isModified()) {
+      toolbar.deactivateRun();
+      Messages.showMessage(Language.text("menu.file.save"),
+                           Language.text("tweak_mode.save_before_tweak"));
+      return;
+    }
+
     new Thread(new Runnable() {
       public void run() {
-        prepareRun();
         try {
-//          toolbar.activate(JavaToolbar.RUN);
-          toolbar.activateRun();
           runtime = jmode.handleTweak(sketch, JavaEditor.this);
         } catch (Exception e) {
-          statusError(e);
+          EventQueue.invokeLater(() -> statusError(e));
         }
       }
     }).start();
diff --git a/java/src/processing/mode/java/JavaMode.java b/java/src/processing/mode/java/JavaMode.java
@@ -144,13 +144,6 @@ public Runner handleTweak(Sketch sketch,
 //                            final boolean present) throws SketchException {
     final JavaEditor editor = (JavaEditor) listener;
 
-    if (isSketchModified(sketch)) {
-      editor.deactivateRun();
-      Messages.showMessage(Language.text("menu.file.save"),
-                           Language.text("tweak_mode.save_before_tweak"));
-      return null;
-    }
-
     // first try to build the unmodified code
     JavaBuild build = new JavaBuild(sketch);
 //    String appletClassName = build.build(false);
