Checkstyle: fixed ModifierOrder.

KostyaSha · KostyaSha · commit a2c6773a037f · 2016-02-02T18:03:49.000+03:00
ModifierOrder: 'static' modifier out of order with the JLS suggestions.
diff --git a/src/main/java/com/github/dockerjava/core/async/ResultCallbackTemplate.java b/src/main/java/com/github/dockerjava/core/async/ResultCallbackTemplate.java
@@ -25,7 +25,7 @@
 public abstract class ResultCallbackTemplate<RC_T extends ResultCallback<A_RES_T>, A_RES_T> implements
         ResultCallback<A_RES_T> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(ResultCallbackTemplate.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ResultCallbackTemplate.class);
 
     private final CountDownLatch started = new CountDownLatch(1);
 
diff --git a/src/main/java/com/github/dockerjava/core/command/AbstrDockerCmd.java b/src/main/java/com/github/dockerjava/core/command/AbstrDockerCmd.java
@@ -19,7 +19,7 @@
 
 public abstract class AbstrDockerCmd<CMD_T extends DockerCmd<RES_T>, RES_T> implements SyncDockerCmd<RES_T> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(AbstrDockerCmd.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(AbstrDockerCmd.class);
 
     protected DockerCmdSyncExec<CMD_T, RES_T> execution;
 
diff --git a/src/main/java/com/github/dockerjava/core/command/AttachContainerResultCallback.java b/src/main/java/com/github/dockerjava/core/command/AttachContainerResultCallback.java
@@ -16,7 +16,7 @@
  */
 public class AttachContainerResultCallback extends ResultCallbackTemplate<AttachContainerResultCallback, Frame> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(AttachContainerResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(AttachContainerResultCallback.class);
 
     @Override
     public void onNext(Frame item) {
diff --git a/src/main/java/com/github/dockerjava/core/command/BuildImageResultCallback.java b/src/main/java/com/github/dockerjava/core/command/BuildImageResultCallback.java
@@ -21,7 +21,7 @@
  */
 public class BuildImageResultCallback extends ResultCallbackTemplate<BuildImageResultCallback, BuildResponseItem> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(BuildImageResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(BuildImageResultCallback.class);
 
     @CheckForNull
     private BuildResponseItem latestItem = null;
diff --git a/src/main/java/com/github/dockerjava/core/command/EventsResultCallback.java b/src/main/java/com/github/dockerjava/core/command/EventsResultCallback.java
@@ -16,7 +16,7 @@
  */
 public class EventsResultCallback extends ResultCallbackTemplate<EventsResultCallback, Event> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(EventsResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(EventsResultCallback.class);
 
     @Override
     public void onNext(Event item) {
diff --git a/src/main/java/com/github/dockerjava/core/command/ExecStartResultCallback.java b/src/main/java/com/github/dockerjava/core/command/ExecStartResultCallback.java
@@ -16,7 +16,7 @@
  */
 public class ExecStartResultCallback extends ResultCallbackTemplate<ExecStartResultCallback, Frame> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(ExecStartResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(ExecStartResultCallback.class);
 
     private OutputStream stdout, stderr;
 
diff --git a/src/main/java/com/github/dockerjava/core/command/LogContainerResultCallback.java b/src/main/java/com/github/dockerjava/core/command/LogContainerResultCallback.java
@@ -16,7 +16,7 @@
  */
 public class LogContainerResultCallback extends ResultCallbackTemplate<LogContainerResultCallback, Frame> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(LogContainerResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(LogContainerResultCallback.class);
 
     @Override
     public void onNext(Frame item) {
diff --git a/src/main/java/com/github/dockerjava/core/command/PullImageResultCallback.java b/src/main/java/com/github/dockerjava/core/command/PullImageResultCallback.java
@@ -19,7 +19,7 @@
  */
 public class PullImageResultCallback extends ResultCallbackTemplate<PullImageResultCallback, PullResponseItem> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(PullImageResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(PullImageResultCallback.class);
 
     @CheckForNull
     private PullResponseItem latestItem = null;
diff --git a/src/main/java/com/github/dockerjava/core/command/PushImageResultCallback.java b/src/main/java/com/github/dockerjava/core/command/PushImageResultCallback.java
@@ -19,7 +19,7 @@
  */
 public class PushImageResultCallback extends ResultCallbackTemplate<PushImageResultCallback, PushResponseItem> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(PushImageResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(PushImageResultCallback.class);
 
     @CheckForNull
     private PushResponseItem latestItem = null;
diff --git a/src/main/java/com/github/dockerjava/core/command/WaitContainerResultCallback.java b/src/main/java/com/github/dockerjava/core/command/WaitContainerResultCallback.java
@@ -21,7 +21,7 @@
  */
 public class WaitContainerResultCallback extends ResultCallbackTemplate<WaitContainerResultCallback, WaitResponse> {
 
-    private final static Logger LOGGER = LoggerFactory.getLogger(WaitContainerResultCallback.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(WaitContainerResultCallback.class);
 
     @CheckForNull
     private WaitResponse waitResponse = null;
diff --git a/src/main/java/com/github/dockerjava/jaxrs/connector/ApacheConnector.java b/src/main/java/com/github/dockerjava/jaxrs/connector/ApacheConnector.java
@@ -182,7 +182,7 @@
 @SuppressWarnings("deprecation")
 class ApacheConnector implements Connector {
 
-    private final static Logger LOGGER = Logger.getLogger(ApacheConnector.class.getName());
+    private static final Logger LOGGER = Logger.getLogger(ApacheConnector.class.getName());
 
     private static final VersionInfo VERSION_INFO;
 
diff --git a/src/test/resources/checkstyle/checkstyle-config.xml b/src/test/resources/checkstyle/checkstyle-config.xml
@@ -114,6 +114,8 @@
         <!--<module name="WhitespaceAround"/>-->
 
         <!-- Modifier Checks                                    -->
+        <!-- See http://checkstyle.sf.net/config_modifiers.html -->
+        <module name="ModifierOrder"/>
         <!-- Verify with @marcuslinke before. 576 violations -->
         <!--<module name="RedundantModifier"/>-->
 
