Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: diffgram/diffgram
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: diffgram/diffgram
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: improve-jobs-edge-cases
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 7 files changed
  • 1 contributor

Commits on Jul 26, 2023

  1. Further align docker file

    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    eda47eb View commit details
    Browse the repository at this point in the history

  2. Clean old code and add limit

    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    76aaa60 View commit details
    Browse the repository at this point in the history

  3. Refactor and align for compound file

    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    adaf086 View commit details
    Browse the repository at this point in the history

  4. Remove Legacy code 

    -> may_attach_to_job() only fires if `input.job_id` (job_id) is supplied.
This was from a legacy context where you could directly attach a file to a job. Now we always are putting it in a directory first. So this code just confuses and potentially conflicts with `update_jobs_with_attached_dirs` which has `job_sync_dir_manger` already
    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e5c43d8 View commit details
    Browse the repository at this point in the history

  5. refactor into create_all_tasks_for_new_file 

    -> Pull the assumptions around creating tasks out of process media and into class
-> Use class in compound file context
-> Small refactor __update_input
    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fb18678 View commit details
    Browse the repository at this point in the history

  6. align

    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    059c539 View commit details
    Browse the repository at this point in the history

  7. Update main.py

    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    80874e4 View commit details
    Browse the repository at this point in the history

  8. Update job_dir_sync_utils.py

    @anthony-chaudhary
    anthony-chaudhary committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2eafcae View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. remove legacy code

    @anthony-chaudhary
    anthony-chaudhary committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6016d93 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'master' into improve-jobs-edge-cases

    @anthony-chaudhary
    anthony-chaudhary committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a6a61d1 View commit details
    Browse the repository at this point in the history
Loading