Skip to content

Commit cf99463

Browse files
Merge pull request #1617 from diffgram/local-install-remote-db-health-check-fix
make healthcheck variable
2 parents b5ef76b + bc44bfa commit cf99463

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

‎docker-compose.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ services:
106106
hostname: db
107107
restart: always
108108
healthcheck:
109-
test: [ "CMD-SHELL", "pg_isready", "-d", "db_prod" ]
109+
test: ['CMD-SHELL', ${HEALTHCHECK_TEST_COMMAND}, ${HEALTHCHECK_TEST_ARG_0}, ${HEALTHCHECK_TEST_ARG_1}]
110110
interval: 30s
111111
timeout: 60s
112112
retries: 5

‎install.py‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -524,21 +524,26 @@ def populate_env(self):
524524
env_file += f"RABBITMQ_PORT={self.rabbit_port}\n"
525525

526526
if self.local_database:
527-
env_file += "POSTGRES_IMAGE=postgres:12.5\n"
527+
env_file += "POSTGRES_IMAGE=postgres:16\n"
528528
env_file += "DATABASE_URL=postgresql+psycopg2://postgres:postgres@db/diffgram\n"
529529
env_file += "DATABASE_NAME=diffgram\n"
530530
env_file += "DATABASE_HOST=db\n"
531531
env_file += "DATABASE_NAME=diffgram\n"
532532
env_file += "DATABASE_USER=postgres\n"
533533
env_file += "DATABASE_PASS=postgres\n"
534-
534+
env_file += "HEALTHCHECK_TEST_COMMAND=pg_isready\n"
535+
env_file += "HEALTHCHECK_TEST_ARG_0=-d\n"
536+
env_file += "HEALTHCHECK_TEST_ARG_1=db_prod\n"
535537
else:
536538
env_file += "POSTGRES_IMAGE=tianon/true\n"
537539
env_file += f"DATABASE_URL={self.database_url}\n"
538540
env_file += f"DATABASE_HOST={self.db_host}\n"
539541
env_file += f"DATABASE_NAME={self.db_name}\n"
540542
env_file += f"DATABASE_USER={self.db_username}\n"
541543
env_file += f"DATABASE_PASS={self.db_pass}\n"
544+
env_file += "HEALTHCHECK_TEST_COMMAND=echo\n"
545+
env_file += "HEALTHCHECK_TEST_ARG_0=remote_db_in_use\n"
546+
env_file += "HEALTHCHECK_TEST_ARG_1=none\n"
542547

543548
if self.mailgun:
544549
env_file += f"MAILGUN_KEY={self.mailgun_key}\n"

0 commit comments

Comments
 (0)