Skip to content

Commit 1aa8983

Browse files
committed
JUnit tests for frames and Javadocs
1 parent ebd6f0e commit 1aa8983

20 files changed

+1069
-414
lines changed

src/main/java/org/java_websocket/WebSocketImpl.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,16 @@ private void close( int code, String message, boolean remote ) {
454454
wsl.onWebsocketError( this, e );
455455
}
456456
}
457-
sendFrame( new CloseFrame( code, message ) );
457+
CloseFrame closeFrame = new CloseFrame();
458+
closeFrame.setReason(message);
459+
closeFrame.setCode(code);
460+
try {
461+
closeFrame.isValid();
462+
sendFrame(closeFrame);
463+
} catch (InvalidDataException e) {
464+
//Rethrow invalid data exception
465+
throw e;
466+
}
458467
} catch ( InvalidDataException e ) {
459468
wsl.onWebsocketError( this, e );
460469
flushAndClose( CloseFrame.ABNORMAL_CLOSE, "generated frame is invalid", false );

src/main/java/org/java_websocket/drafts/Draft_76.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,10 @@ public List<Framedata> translateFrame( ByteBuffer buffer ) throws InvalidDataExc
209209
}
210210
if( !currentFrame.hasRemaining() ) {
211211
if( Arrays.equals( currentFrame.array(), closehandshake ) ) {
212-
frames.add( new CloseFrame( CloseFrame.NORMAL ) );
212+
CloseFrame closeFrame = new CloseFrame();
213+
closeFrame.setCode(CloseFrame.NORMAL);
214+
closeFrame.isValid();
215+
frames.add(closeFrame);
213216
return frames;
214217
}
215218
else{
Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
package org.java_websocket.framing;
22

33
/**
4-
* Created by Admin on 23.05.2017.
4+
* Class to represent a binary frame
55
*/
66
public class BinaryFrame extends DataFrame {
7-
public BinaryFrame() {
8-
super( Opcode.BINARY );
9-
}
7+
8+
/**
9+
* constructor which sets the opcode of this frame to binary
10+
*/
11+
public BinaryFrame() {
12+
super(Opcode.BINARY);
13+
}
1014
}

0 commit comments

Comments
 (0)