Fixed #10396 (FP missingReturn on void operator=())

danmar · danmar · commit c2305b1da7a0 · 2021-08-10T09:55:16.000+02:00
diff --git a/lib/symboldatabase.cpp b/lib/symboldatabase.cpp
@@ -2692,7 +2692,7 @@ bool Function::returnsVoid(const Function* function, bool unknown)
 {
     if (!function)
         return false;
-    if (function->type != Function::eFunction)
+    if (function->type != Function::eFunction && function->type != Function::eOperatorEqual)
         return false;
     const Token* defEnd = function->returnDefEnd();
     if (defEnd->strAt(-1) == "void")
diff --git a/test/testfunctions.cpp b/test/testfunctions.cpp
@@ -1398,6 +1398,9 @@ class TestFunctions : public TestFixture {
         check("void STDCALL foo() {}");
         ASSERT_EQUALS("", errout.str());
 
+        check("void operator=(int y) { x=y; }");
+        ASSERT_EQUALS("", errout.str());
+
         check("int f() {\n"
               "back:\n"
               "    return 0;\n"

Original file line number	Diff line number	Diff line change
`@@ -2692,7 +2692,7 @@ bool Function::returnsVoid(const Function* function, bool unknown)`
`2692`	`2692`	`{`
`2693`	`2693`	`if (!function)`
`2694`	`2694`	`return false;`
`2695`		`- if (function->type != Function::eFunction)`
	`2695`	`+ if (function->type != Function::eFunction && function->type != Function::eOperatorEqual)`
`2696`	`2696`	`return false;`
`2697`	`2697`	`const Token* defEnd = function->returnDefEnd();`
`2698`	`2698`	`if (defEnd->strAt(-1) == "void")`