Skip to content

Commit aef63e7

Browse files
josephperrottAndrewKushnir
josephperrott
authored and
AndrewKushnir
committed
build: remove "ivy-only" bazel tag (angular#43862)
Because all actions are assumed to be running on Ivy, things which only work on Ivy should not be marked as Ivy only. PR Close angular#43862
1 parent a365a1f commit aef63e7

30 files changed

Lines changed: 36 additions & 288 deletions

File tree

‎.circleci/config.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ jobs:
303303
- init_environment
304304
- install_java
305305
- run:
306-
command: yarn bazel test //... --build_tag_filters=-ivy-only --test_tag_filters=-ivy-only
306+
command: yarn test //...
307307
no_output_timeout: 20m
308308

309309
# Temporary job to test what will happen when we flip the Ivy flag to true
@@ -776,11 +776,11 @@ jobs:
776776
- setup_win
777777
- run:
778778
name: Build all windows CI targets
779-
command: bazel build --config=view-engine --build_tag_filters=-ivy-only //packages/compiler-cli/...
779+
command: bazel build --config=view-engine --build_tag_filters=view-engine-only //packages/compiler-cli/...
780780
no_output_timeout: 15m
781781
- run:
782782
name: Test all windows CI targets
783-
command: bazel test --config=view-engine --test_tag_filters="-ivy-only,-browser:chromium-local" //packages/compiler-cli/...
783+
command: bazel test --config=view-engine --test_tag_filters="view-engine-only,-browser:chromium-local" //packages/compiler-cli/...
784784
no_output_timeout: 15m
785785

786786
test_ivy_aot_win:

‎integration/BUILD.bazel‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,33 +33,25 @@ INTEGRATION_TESTS = {
3333
"manual",
3434
],
3535
},
36-
"cli-elements-universal": {
37-
"tags": ["ivy-only"],
38-
},
36+
"cli-elements-universal": {},
3937
"cli-hello-world": {
4038
"commands": "payload_size_tracking",
41-
"tags": ["ivy-only"],
4239
},
4340
"cli-hello-world-ivy-compat": {
4441
"commands": "payload_size_tracking",
45-
"tags": ["ivy-only"],
4642
},
4743
"cli-hello-world-ivy-i18n": {
4844
"commands": "payload_size_tracking",
49-
"tags": ["ivy-only"],
5045
},
5146
"cli-hello-world-ivy-minimal": {
5247
"commands": "payload_size_tracking",
53-
"tags": ["ivy-only"],
5448
},
5549
"cli-hello-world-lazy": {
5650
"commands": "payload_size_tracking",
57-
"tags": ["ivy-only"],
5851
},
5952
"dynamic-compiler": {},
6053
"forms": {
6154
"commands": "payload_size_tracking",
62-
"tags": ["ivy-only"],
6355
},
6456
"hello_world__closure": {
6557
# TODO: Re-enable the payload_size_tracking command:

‎modules/benchmarks/src/largetable/render3/BUILD.bazel‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ ng_module(
1010
"index_aot.ts",
1111
"table.ts",
1212
],
13-
tags = ["ivy-only"],
1413
deps = [
1514
"//modules/benchmarks/src:util_lib",
1615
"//modules/benchmarks/src/largetable:util_lib",
@@ -23,7 +22,6 @@ ng_module(
2322
ng_rollup_bundle(
2423
name = "bundle",
2524
entry_point = ":index_aot.ts",
26-
tags = ["ivy-only"],
2725
deps = [
2826
":largetable_lib",
2927
"@npm//rxjs",
@@ -34,7 +32,6 @@ ts_devserver(
3432
name = "devserver",
3533
port = 4200,
3634
static_files = ["index.html"],
37-
tags = ["ivy-only"],
3835
deps = [
3936
":bundle.min_debug.js",
4037
],
@@ -43,13 +40,11 @@ ts_devserver(
4340
benchmark_test(
4441
name = "perf",
4542
server = ":devserver",
46-
tags = ["ivy-only"],
4743
deps = ["//modules/benchmarks/src/largetable:perf_tests_lib"],
4844
)
4945

5046
e2e_test(
5147
name = "e2e",
5248
server = ":devserver",
53-
tags = ["ivy-only"],
5449
deps = ["//modules/benchmarks/src/largetable:e2e_tests_lib"],
5550
)

‎modules/benchmarks/src/tree/render3/BUILD.bazel‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ ng_module(
1010
"index_aot.ts",
1111
"tree.ts",
1212
],
13-
tags = ["ivy-only"],
1413
deps = [
1514
"//modules/benchmarks/src/tree:util_lib",
1615
"//packages:types",
@@ -22,7 +21,6 @@ ng_module(
2221
ng_rollup_bundle(
2322
name = "bundle",
2423
entry_point = ":index_aot.ts",
25-
tags = ["ivy-only"],
2624
deps = [
2725
":tree_lib",
2826
"@npm//rxjs",
@@ -33,14 +31,12 @@ ts_devserver(
3331
name = "devserver",
3432
port = 4200,
3533
static_files = ["index.html"],
36-
tags = ["ivy-only"],
3734
deps = [":bundle.min_debug.js"],
3835
)
3936

4037
benchmark_test(
4138
name = "perf",
4239
server = ":devserver",
43-
tags = ["ivy-only"],
4440
deps = [
4541
"//modules/benchmarks/src/tree:detect_changes_perf_tests_lib",
4642
"//modules/benchmarks/src/tree:perf_tests_lib",
@@ -50,7 +46,6 @@ benchmark_test(
5046
e2e_test(
5147
name = "e2e",
5248
server = ":devserver",
53-
tags = ["ivy-only"],
5449
deps = [
5550
"//modules/benchmarks/src/tree:detect_changes_e2e_tests_lib",
5651
"//modules/benchmarks/src/tree:e2e_tests_lib",

‎packages/bazel/test/ngc-wrapped/ivy_enabled/BUILD.bazel‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ ts_library(
55
name = "ng_module_ivy_test_lib",
66
testonly = True,
77
srcs = ["ng_module_ivy_test.ts"],
8-
tags = ["ivy-only"],
8+
tags = [],
99
deps = ["@npm//@bazel/runfiles"],
1010
)
1111

1212
ng_module(
1313
name = "test_module_default_compilation",
1414
srcs = ["test_module_default_compilation.ts"],
15-
tags = ["ivy-only"],
15+
tags = [],
1616
deps = ["//packages/core"],
1717
)
1818

@@ -22,20 +22,20 @@ jasmine_node_test(
2222
data = [
2323
":test_module_default_compilation",
2424
],
25-
tags = ["ivy-only"],
25+
tags = [],
2626
)
2727

2828
ng_module(
2929
name = "test_module_warnings_lib",
3030
srcs = ["test_module_warnings.ts"],
3131
experimental_extended_template_diagnostics = True,
3232
strict_templates = True,
33-
tags = ["ivy-only"],
33+
tags = [],
3434
deps = ["//packages/core"],
3535
)
3636

3737
build_test(
3838
name = "test_module_warnings",
39-
tags = ["ivy-only"],
39+
tags = [],
4040
targets = [":test_module_warnings_lib"],
4141
)

‎packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ng_module(
1010
],
1111
),
1212
module_name = "app_built",
13-
tags = ["ivy-only"],
13+
tags = [],
1414
deps = [
1515
"//packages/core",
1616
"@npm//rxjs",

‎packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ ts_library(
1010
"**/*.ts",
1111
],
1212
),
13-
tags = [
14-
"ivy-only",
15-
],
1613
deps = [
1714
"//packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app",
1815
"//packages/core",
@@ -23,9 +20,6 @@ ts_library(
2320
jasmine_node_test(
2421
name = "test",
2522
bootstrap = ["//tools/testing:node_es5"],
26-
tags = [
27-
"ivy-only",
28-
],
2923
deps = [
3024
":test_lib",
3125
],

‎packages/compiler-cli/ngcc/test/BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jasmine_node_test(
9898
"@npm//rxjs",
9999
],
100100
shard_count = 4,
101-
tags = ["ivy-only"],
101+
tags = [],
102102
templated_args = [
103103
# TODO(josephperrott): update dependency usages to no longer need bazel patch module resolver
104104
# See: https://github.com/bazelbuild/rules_nodejs/wiki#--bazel_patch_module_resolver-now-defaults-to-false-2324

‎packages/compiler-cli/test/compliance/full/BUILD.bazel‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ jasmine_node_test(
1818
"//packages/compiler-cli/test/compliance/test_cases",
1919
],
2020
shard_count = 2,
21-
tags = [
22-
"ivy-only",
23-
],
2421
deps = [
2522
":test_lib",
2623
],

‎packages/compiler-cli/test/compliance/linked/BUILD.bazel‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ jasmine_node_test(
2323
"//packages/compiler-cli/test/compliance/test_cases",
2424
],
2525
shard_count = 2,
26-
tags = [
27-
"ivy-only",
28-
],
2926
deps = [
3027
":test_lib",
3128
],

0 commit comments

Comments
 (0)