allow borrowing from NewReference

lostmsu · lostmsu · commit 638dc1c7772f · 2020-03-16T23:22:27.000-07:00
implemented as an implicit conversion
diff --git a/src/embed_tests/References.cs b/src/embed_tests/References.cs
@@ -36,5 +36,20 @@ public void MoveToPyObject_SetsNull()
                 reference.Dispose();
             }
         }
+
+        [Test]
+        public void CanBorrowFromNewReference()
+        {
+            var dict = new PyDict();
+            NewReference reference = Runtime.PyDict_Items(dict.Handle);
+            try
+            {
+                PythonException.ThrowIfIsNotZero(Runtime.PyList_Reverse(reference));
+            }
+            finally
+            {
+                reference.Dispose();
+            }
+        }
     }
 }
diff --git a/src/runtime/NewReference.cs b/src/runtime/NewReference.cs
@@ -11,6 +11,10 @@ ref struct NewReference
     {
         IntPtr pointer;
 
+        [Pure]
+        public static implicit operator BorrowedReference(in NewReference reference)
+            => new BorrowedReference(reference.pointer);
+
         /// <summary>
         /// Returns <see cref="PyObject"/> wrapper around this reference, which now owns
         /// the pointer. Sets the original reference to <c>null</c>, as it no longer owns it.
@@ -36,6 +40,7 @@ public void Dispose()
         /// <summary>
         /// Creates <see cref="NewReference"/> from a raw pointer
         /// </summary>
+        [Pure]
         public static NewReference DangerousFromPointer(IntPtr pointer)
             => new NewReference {pointer = pointer};
 

Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,20 @@ public void MoveToPyObject_SetsNull()`
`36`	`36`	`reference.Dispose();`
`37`	`37`	`}`
`38`	`38`	`}`
	`39`	`+`
	`40`	`+ [Test]`
	`41`	`+ public void CanBorrowFromNewReference()`
	`42`	`+ {`
	`43`	`+ var dict = new PyDict();`
	`44`	`+ NewReference reference = Runtime.PyDict_Items(dict.Handle);`
	`45`	`+ try`
	`46`	`+ {`
	`47`	`+ PythonException.ThrowIfIsNotZero(Runtime.PyList_Reverse(reference));`
	`48`	`+ }`
	`49`	`+ finally`
	`50`	`+ {`
	`51`	`+ reference.Dispose();`
	`52`	`+ }`
	`53`	`+ }`
`39`	`54`	`}`
`40`	`55`	`}`