This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[Scopes] Avoid exceptions when import bindings are optimized away.#5722
Merged
jasonLaster merged 1 commit intoMar 20, 2018
Merged
Conversation
825e911 to
b6f5d3c
Compare
jasonLaster
approved these changes
Mar 19, 2018
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the comments and the tests.
I feel better about this code now than before, which is impressive given that we’re handling some difficult cases
b6f5d3c to
14a9873
Compare
14a9873 to
4e5d14f
Compare
jasonLaster
pushed a commit
that referenced
this pull request
Mar 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs Issue: #5561
Summary of Changes