Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Open quick open without prefix selected#5715

Merged
darkwing merged 1 commit into
firefox-devtools:masterfrom
MarkPollmann:quickopen-unselect-prefix
Mar 19, 2018
Merged

Open quick open without prefix selected#5715
darkwing merged 1 commit into
firefox-devtools:masterfrom
MarkPollmann:quickopen-unselect-prefix

Conversation

@MarkPollmann

Copy link
Copy Markdown
Contributor

Fixes Issue: #5710

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  • set the hasPrefix prop of the SearchInput component to true
  • update jest snapshots

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • Command-Shift-O opens the panel
  • Check that the prefix (@) is not selected
  • Start typing without deletion of the prefix

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

Screenshots/Videos (OPTIONAL)

unselected-prefix

@darkwing darkwing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @MarkPollmann !!

@darkwing darkwing merged commit cb8ed00 into firefox-devtools:master Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants