This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Enhancement add contenxt menu copy to clipboard#5704
Merged
bomsy merged 4 commits intoMar 18, 2018
Merged
Conversation
added 2 commits
March 17, 2018 16:12
…u, Tab Contenxt Menu)
…all to getRawSourceURL.
flodolo
suggested changes
Mar 17, 2018
|
|
||
| # LOCALIZATION NOTE (copyToClipboard): This is the text that appears in the | ||
| # context menu to copy the complete source of file open. | ||
| copyToClipboard=Copy to clipboard |
There was a problem hiding this comment.
Please use copyToClipboard.label for this one (and update the reference in the commit accordingly)
nit on comment: "of file open" -> "of the open file"
flodolo
reviewed
Mar 17, 2018
| # that collapses the left and right panes in the debugger UI. | ||
| collapsePanes=Collapse panes | ||
|
|
||
| # LOCALIZATION NOTE (copyToClipboard): This is the text that appears in the |
There was a problem hiding this comment.
You need to change it here too (copyToClipboard.label).
flodolo
approved these changes
Mar 17, 2018
flodolo
left a comment
There was a problem hiding this comment.
Thanks, changes to the .properties file look good. Leaving the code to a suitable reviewer ;-)
AnshulMalik
approved these changes
Mar 18, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Mar 21, 2018
* Add copy to clipboard item to context menus(Source Editor Context Menu, Tab Contenxt Menu) * Change context menu label to 'Copy to clipboard'. Avoid unnecessary call to getRawSourceURL. * Change "copyToClipboard" to "copyToClipboard.label" in debugger.properties. * Change in Localization note for copyToClipboard.label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5341
Summary of Changes
Test Plan
Open any source using Command + P
Go to Editor and open context menu (right+click)
Clicking on "Copy to clipboard" copies current source to clipboard
Try to paste to copied source somewhere else. It should match currently open editor source.
Right click on source tab panel
Context menu is expected to show item "Copy to clipboard"
If you have open context menu on tab of currently selected source, then "Copy to clipboard" should be in enabled state.
Click on "Copy to clipboard" item, it should have copied currently open source to clipboard.
Try pasting copied source somewhere else.
Screenshots/Videos (OPTIONAL)