Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Make SourceRecord fields Read-Only#5703

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
AnshulMalik:source-object-flow
Mar 17, 2018
Merged

Make SourceRecord fields Read-Only#5703
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
AnshulMalik:source-object-flow

Conversation

@AnshulMalik

@AnshulMalik AnshulMalik commented Mar 17, 2018

Copy link
Copy Markdown
Contributor

Fixes: #5657

Summary of Changes

  • Make source record fields read-only

Test Plan

  • yarn flow
  • source.id = "asdf" throws error, saying id is read only property :)

@jasonLaster jasonLaster merged commit 192c760 into firefox-devtools:master Mar 17, 2018
@AnshulMalik AnshulMalik deleted the source-object-flow branch March 17, 2018 14:54
jasonLaster pushed a commit that referenced this pull request Mar 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants