This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Lock down parser flow type exports#5674
Merged
Merged
Conversation
41e05ba to
1c74c4b
Compare
jasonLaster
commented
Mar 14, 2018
| } else { | ||
| match = getExpressionFromCoords(editor.codeMirror, tokenPos); | ||
| } else { | ||
| match = findBestMatchExpression(symbols, tokenPos); |
Contributor
Author
There was a problem hiding this comment.
yikes. really helpful catch
| location: BabelLocation, | ||
| parent?: ClassDeclaration | ||
| |}; | ||
| import type { SimplePath } from "./utils/simple-path"; |
Contributor
Author
There was a problem hiding this comment.
just being consistent. i kinda like how it can be more concise, but we dont do it anywhere else
loganfsmyth
reviewed
Mar 14, 2018
| import type { Position } from "../types"; | ||
| import type { SymbolDeclarations } from "../workers/parser"; | ||
|
|
||
| export function findBestMatchExpression( |
Contributor
There was a problem hiding this comment.
Your fix seems more like the right one, but I'll add that the immediate thing that jumped out to me when I looked is that this function's return type is still weird. It should be SymbolDeclaration | null or something, but it is SymbolDeclaration | {} right now. That means if you were in a file that doesn't have any identifiers, it still looks like it found something.
448abdb to
c8a4325
Compare
Contributor
Author
|
cool, this will be fixed in the pause points work |
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes