This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix computed member expressions#5655
Merged
Merged
Conversation
jasonLaster
approved these changes
Mar 12, 2018
Contributor
|
Looks good. Just some flow noise |
…into computed-expr
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Mar 16, 2018
* Fix computed member expressions * add more fixtures for computed properties * tweaks * fix flow issues
juliandescottes
pushed a commit
that referenced
this pull request
Apr 4, 2018
* Fix computed member expressions * add more fixtures for computed properties * tweaks * fix flow issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5378
Summary of Changes
isComputedExpressionutil to check if an expression string is computed or not.extra.rawinstead of.valueadds the quotes for string literals so that we do not need to try to handle that.