WIP - React Components Show React Logo#4728
Conversation
| activeSearch: getActiveSearch(state), | ||
| searchOn: getActiveSearch(state) === "source" | ||
| searchOn: getActiveSearch(state) === "source", | ||
| sourceMetaData: getSourceMetaData(state, 0) |
There was a problem hiding this comment.
@jasonLaster I was actually having a problem with how to fetch the sourceId for getSourceMetaData
| activeSearch: getActiveSearch(state), | ||
| searchOn: getActiveSearch(state) === "source" | ||
| searchOn: getActiveSearch(state) === "source", | ||
| sourceMetaData: { isReactComponent: true } |
There was a problem hiding this comment.
Hard-coded for now so I could complete the rest of the task, what should go here because I can't figure it out? 😢
There was a problem hiding this comment.
@James300 You can do this
@@ -484,13 +484,15 @@ class SourceTabs extends PureComponent<Props, State> {
export default connect(
state => {
+ const selectedSource = getSelectedSource(state);
+ const sourceId = selectedSource ? selectedSource.get("id") : "";
return {
- selectedSource: getSelectedSource(state),
+ selectedSource,
searchTabs: getSearchTabs(state),
sourceTabs: getSourcesForTabs(state),
activeSearch: getActiveSearch(state),
searchOn: getActiveSearch(state) === "source",
- sourceMetaData: { isReactComponent: true }
+ sourceMetaData: getSourceMetaData(state, sourceId)
};
},
dispatch => bindActionCreators(actions, dispatch)I think there is still the work to set the sourceMetaData in redux
There was a problem hiding this comment.
Thank Bomsy this did it 👍
|
I noticed a few problems with the framework
Also, the React Icon does not show when reloading previously opened files. |
| padding-top: 12px; | ||
| height: 14px; | ||
| width: 14px; | ||
| background: var(--theme-highlight-blue); |
There was a problem hiding this comment.
dark mode might benefit from a different color... something darker...
There was a problem hiding this comment.
This is using bluegrey, thoughts?
Associated Issue: #4151
Summary of Changes
Screenshots
The icon seems a little small, thoughts?