Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Accessibility] command bar buttons accessibility#4710

Merged
bomsy merged 8 commits into
firefox-devtools:masterfrom
cvetanovskaa:master
Nov 18, 2017
Merged

[Accessibility] command bar buttons accessibility#4710
bomsy merged 8 commits into
firefox-devtools:masterfrom
cvetanovskaa:master

Conversation

@cvetanovskaa

Copy link
Copy Markdown
Contributor

Associated Issue: #4078

Summary of Changes

  • Aria-label from Command Bar Buttons is removed, since it was redundant
  • Aria-pressed attribute was added to the PauseOnExceptions button

Test Plan

  1. run yarn start and open the debugger.
  2. Right click on the pause on exceptions button and click inspect element
  3. Then click the pause on exceptions button at least 3 times and look at the elements and make sure the boolean value change correctly.

Screenshots

The code of the debug button, after the changes:
screenshot from 2017-11-14 11-33-05

The code of the PauseOnExceptions button, after the changes:
exceptionsbtn

@jasonLaster jasonLaster changed the title Fixes #4078 [Accessibility] command bar buttons accessibility Nov 16, 2017
@jasonLaster

Copy link
Copy Markdown
Contributor

Thanks! this looks good. I'll defer to @Garbee and @yzen for accessibility reviews

@yzen

yzen commented Nov 18, 2017

Copy link
Copy Markdown
Contributor

Looks good from accessibility standpoint. Thanks!

@bomsy bomsy merged commit 08519dc into firefox-devtools:master Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants