This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix 4690 [PrettyPrint] enable “Jump to Generated Location"#4698
Merged
Conversation
bomsy
reviewed
Nov 15, 2017
| const jumpLabel = { | ||
| accesskey: L10N.getStr("editor.jumpToMappedLocation1.accesskey"), | ||
| disabled: isGeneratedId && !hasSourceMap, | ||
| disabled: isGenerated && !hasSourceMap && !hasPrettyPrint, |
Contributor
There was a problem hiding this comment.
Maybe we also check isPrettyPrinted since we have it anyways
i.e disabled: isGenerated && !hasSourceMap && (!hasPrettyPrint || !isPrettyPrinted),
Contributor
There was a problem hiding this comment.
yep, i like naming these bools:
isPretty = hasPrettyPrint || !isPrettyPrinted
noMap = isGenerated && !hasSourceMap
or something like that. noMap is clearly a bad name
Contributor
Author
There was a problem hiding this comment.
i changed the code to include both comments. please check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #4690
Summary of Changes
Test Plan
Screenshots