Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Adding MobX to framework frames feature#4687

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
jacobjzhang:jz/add-mobx
Nov 14, 2017
Merged

Adding MobX to framework frames feature#4687
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
jacobjzhang:jz/add-mobx

Conversation

@jacobjzhang

Copy link
Copy Markdown
Contributor

Associated Issue: #4661

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  • Added MobX svg asset
  • Added logic to detect mobx files

Test Plan

Screenshots/Videos (OPTIONAL)

image

@jasonLaster

Copy link
Copy Markdown
Contributor

Mind checking this in dark theme:

Launchpad > settings > theme

@jacobjzhang

Copy link
Copy Markdown
Contributor Author

Good catch, swapped it out for a dark one. Looks way better:

image

@jasonLaster

Copy link
Copy Markdown
Contributor

sweet, mind sharing the light theme again?

@jacobjzhang

Copy link
Copy Markdown
Contributor Author

Np

image

@jasonLaster jasonLaster merged commit 757fb8d into firefox-devtools:master Nov 14, 2017
@amitzur

amitzur commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

👏

@jacobjzhang jacobjzhang deleted the jz/add-mobx branch November 15, 2017 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants