Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Remove Breakpoint Editor management#4677

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
nyrosmith:remove_breakpoint_editor_management
Nov 14, 2017
Merged

Remove Breakpoint Editor management#4677
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
nyrosmith:remove_breakpoint_editor_management

Conversation

@nyrosmith

Copy link
Copy Markdown
Contributor

Associated Issue: #4579

Summary of Changes

  • Remove showSourceText from Breakpoint component

@jasonLaster

Copy link
Copy Markdown
Contributor

Awesome! Lets double and triple check this because we added it before because there were some race conditions:

I think the STR for the old bug, was to have a BP that is in an original source:

  1. add the bp
  2. toggle between original and generated and make sure you see it
  3. remove the bp jump to the other source make sure it's gone...

...

@jasonLaster

Copy link
Copy Markdown
Contributor

Works great!

@jasonLaster jasonLaster merged commit f57e6ef into firefox-devtools:master Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants