This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Upgrade to flow 0.41#2462
Merged
Merged
Conversation
arthur801031
commented
Mar 27, 2017
| // overwrite searchContents with a debounced version to reduce the | ||
| // frequency of queries which improves perf on large files | ||
| // $FlowIgnore | ||
| this.searchContents = debounce(this.searchContents, 100); |
Contributor
Author
There was a problem hiding this comment.
Hi @jasonLaster
Here I disable flow to suppress the error. Are we okay with this approach?
Codecov Report
@@ Coverage Diff @@
## master #2462 +/- ##
=======================================
Coverage 54.43% 54.43%
=======================================
Files 52 52
Lines 2017 2017
Branches 391 391
=======================================
Hits 1098 1098
Misses 919 919Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Mar 27, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
Wow! Really great. Thanks @arthur801031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2293
Summary of Changes
Update the following files to pass flow:
Test Plan
Pass
yarn run flowyarn run testyarn run lint