This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[tests] Fix requiring workers in jest#2431
Merged
Merged
Conversation
f102f74 to
e8d7818
Compare
e8d7818 to
b15e86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2427
Summary of Changes
we're currently seeing issues running the unit tests that touch workers like parser, source maps. The reason for this is that we're no longer pre-bundling the workers. The solution I want to go with is to stop building the workers and instead use workerjs to point to the worker entry file directly.
TO DO: