Jest coverage#2417
Conversation
| "lint-md": "remark -q *.md src/**/*.md configs/*.md docs/**/*.md", | ||
| "lint-fix": "yarn lint-js -- --fix", | ||
| "test": "jest --forceExit", | ||
| "test-coverage": "yarn test -- --coverage", |
There was a problem hiding this comment.
I wasn't sure if we wanted add coverage to the default test script instead of a creating a new one.
There was a problem hiding this comment.
sure - this is probably fine. we can always update this later when we're using flow as well
| "lint-md": "remark -q *.md src/**/*.md configs/*.md docs/**/*.md", | ||
| "lint-fix": "yarn lint-js -- --fix", | ||
| "test": "jest --forceExit", | ||
| "test-coverage": "yarn test -- --coverage", |
There was a problem hiding this comment.
sure - this is probably fine. we can always update this later when we're using flow as well
|
Should we see codecov here? |
Yes, but I turned it off previously since we weren't getting flow coverage. Just turned it back on now. Maybe if I close and reopen this it'll happen... |
|
Adding a fix for the lint issue that I believe came from #2420 |
|
ahh - thanks |
| } | ||
|
|
||
| accordion .header-buttons button::-moz-focus-inner { | ||
| .accordion .header-buttons button::-moz-focus-inner { |
There was a problem hiding this comment.
I also added a . here which is what I believe is needed and was just missed from copy / pasta
|
Coverage is now being reported in CI.
And I'm seeing the JSON artifact: https://400-55521579-gh.circle-artifacts.com/0/tmp/circle-junit.y1G4yTz/jest-coverage/coverage-final.json |
|
Cool! |
Associated Issue: #2319
Summary of Changes
test-coveragescript