Skip to content

Update checks: prevent GitHub rate limit #339

@LukasGentele

Description

@LukasGentele

Is your feature request related to a problem?
Yes, when running commands, we always check for updates by calling the GitHub API. When running many commands in a short time (e.g. devspace status sync), we are hitting the GitHub API rate limit and see this error:

[WARN]   Couldn't check for newest version: GET https://api.github.com/repos/covexo/devspace/releases: 403 API rate limit exceeded for 178.5.106.180. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 8m47s]

Which solution do you suggest?
I suggest running an update service that does the GitHub API request regularly and caches the latest release. When checking for updates, the request should be made against the update service instead of against the GitHub API directly.

Which alternative solutions exist?
Alternatively, we could ask the user for a personal access token for the GitHub API but that would require additional configuration and force users to have a GitHub account.

Additional context

/kind feature

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/upgradeIssues related to devspace upgradekind/enhancementEnhancement of an existing feature / improvement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions