modify api tests to try and do a get after a post [get_after_post]

hjwp · hjwp · commit bd080f2d6e39 · 2021-02-24T20:08:31.000Z
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -14,6 +14,8 @@
 from allocation.adapters.orm import metadata, start_mappers
 from allocation import config
 
+pytest.register_assert_rewrite("tests.e2e.api_client")
+
 
 @pytest.fixture
 def in_memory_db():
diff --git a/tests/e2e/api_client.py b/tests/e2e/api_client.py
@@ -21,5 +21,10 @@ def post_to_allocate(orderid, sku, qty, expect_success=True):
         },
     )
     if expect_success:
-        assert r.status_code == 201
+        assert r.status_code == 202
     return r
+
+
+def get_allocation(orderid):
+    url = config.get_api_url()
+    return requests.get(f"{url}/allocations/{orderid}")
diff --git a/tests/e2e/test_api.py b/tests/e2e/test_api.py
@@ -5,7 +5,8 @@
 
 @pytest.mark.usefixtures("postgres_db")
 @pytest.mark.usefixtures("restart_api")
-def test_happy_path_returns_201_and_allocated_batch():
+def test_happy_path_returns_202_and_batch_is_allocated():
+    orderid = random_orderid()
     sku, othersku = random_sku(), random_sku("other")
     earlybatch = random_batchref(1)
     laterbatch = random_batchref(2)
@@ -14,23 +15,25 @@ def test_happy_path_returns_201_and_allocated_batch():
     api_client.post_to_add_batch(earlybatch, sku, 100, "2011-01-01")
     api_client.post_to_add_batch(otherbatch, othersku, 100, None)
 
-    response = api_client.post_to_allocate(random_orderid(), sku, qty=3)
+    r = api_client.post_to_allocate(orderid, sku, qty=3)
+    assert r.status_code == 202
 
-    assert response.status_code == 201
-    assert response.json()["batchref"] == earlybatch
+    r = api_client.get_allocation(orderid)
+    assert r.ok
+    assert r.json() == [
+        {"sku": sku, "batchref": earlybatch},
+    ]
 
 
 @pytest.mark.usefixtures("postgres_db")
 @pytest.mark.usefixtures("restart_api")
 def test_unhappy_path_returns_400_and_error_message():
     unknown_sku, orderid = random_sku(), random_orderid()
-
-    response = api_client.post_to_allocate(
-        orderid,
-        unknown_sku,
-        qty=20,
-        expect_success=False,
+    r = api_client.post_to_allocate(
+        orderid, unknown_sku, qty=20, expect_success=False
     )
+    assert r.status_code == 400
+    assert r.json()["message"] == f"Invalid sku {unknown_sku}"
 
-    assert response.status_code == 400
-    assert response.json()["message"] == f"Invalid sku {unknown_sku}"
+    r = api_client.get_allocation(orderid)
+    assert r.status_code == 404
