src: silence clang warnings

trevnorris · trevnorris · commit 752585db6355 · 2015-01-20T15:28:05.000-08:00
Mark several methods "override" in order to remove build warnings. PR-URL: nodejs#531 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/src/node_v8_platform.h b/src/node_v8_platform.h
@@ -53,9 +53,9 @@ class Platform : public v8::Platform {
   virtual ~Platform() override;
 
   void CallOnBackgroundThread(v8::Task* task,
-                              ExpectedRuntime expected_runtime);
-  void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task);
-  double MonotonicallyIncreasingTime();
+                              ExpectedRuntime expected_runtime) override;
+  void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override;
+  double MonotonicallyIncreasingTime() override;
 
  protected:
   static void WorkerBody(void* arg);
diff --git a/src/string_bytes.cc b/src/string_bytes.cc
@@ -32,11 +32,11 @@ class ExternString: public ResourceType {
       isolate()->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
     }
 
-    const TypeName* data() const {
+    const TypeName* data() const override {
       return data_;
     }
 
-    size_t length() const {
+    size_t length() const override {
       return length_;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,11 @@ class ExternString: public ResourceType {`
`32`	`32`	`isolate()->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);`
`33`	`33`	`}`
`34`	`34`
`35`		`- const TypeName* data() const {`
	`35`	`+ const TypeName* data() const override {`
`36`	`36`	`return data_;`
`37`	`37`	`}`
`38`	`38`
`39`		`- size_t length() const {`
	`39`	`+ size_t length() const override {`
`40`	`40`	`return length_;`
`41`	`41`	`}`
`42`	`42`