Convert tasks example to use logging for testability (GoogleCloudPlatform#1219)

andrewsg · web-flow · commit 19788b043885 · 2017-11-15T10:46:20.000-08:00
* Convert tasks example to use logging for testability

* Use capsys to test tasks
diff --git a/appengine/flexible/tasks/main_test.py b/appengine/flexible/tasks/main_test.py
@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import mock
 import pytest
 
 
@@ -28,19 +27,19 @@ def test_index(app):
     assert r.status_code == 200
 
 
-@mock.patch('logging.warn')
-def test_log_payload(logging_mock, app):
-    payload = 'hello'
+def test_log_payload(capsys, app):
+    payload = 'test_payload'
 
     r = app.post('/log_payload', data=payload)
     assert r.status_code == 200
 
-    assert logging_mock.called
+    out, _ = capsys.readouterr()
+    assert payload in out
 
 
-@mock.patch('logging.warn')
-def test_empty_payload(logging_mock, app):
+def test_empty_payload(capsys, app):
     r = app.post('/log_payload')
     assert r.status_code == 200
 
-    assert logging_mock.called
+    out, _ = capsys.readouterr()
+    assert 'empty payload' in out
