JAVA-1464: Allow custom codecs with non public constructors in @Param

tsachev · Alexandre Dutra · commit 30937260e1b1 · 2017-05-29T11:02:23.000+02:00
diff --git a/changelog/README.md b/changelog/README.md
@@ -6,6 +6,7 @@
 - [improvement] JAVA-1203: Upgrade Metrics to allow usage in OSGi.
 - [bug] JAVA-1407: KeyspaceMetadata exportAsString should export user types in topological sort order.
 - [bug] JAVA-1455: Mapper support using unset for null values.
+- [bug] JAVA-1464: Allow custom codecs with non public constructors in @Param.
 
 
 ### 3.2.0
diff --git a/driver-mapping/src/main/java/com/datastax/driver/mapping/MethodMapper.java b/driver-mapping/src/main/java/com/datastax/driver/mapping/MethodMapper.java
@@ -16,6 +16,7 @@
 package com.datastax.driver.mapping;
 
 import com.datastax.driver.core.*;
+import com.datastax.driver.mapping.annotations.Defaults;
 import com.google.common.collect.Sets;
 import com.google.common.reflect.TypeToken;
 import com.google.common.util.concurrent.Futures;
@@ -186,14 +187,7 @@ static class ParamMapper {
             this.paramName = paramName;
             this.paramIdx = paramIdx;
             this.paramType = (TypeToken<Object>) paramType;
-            try {
-                this.codec = (codecClass == null) ? null : (TypeCodec<Object>) codecClass.newInstance();
-            } catch (Exception e) {
-                throw new IllegalArgumentException(String.format(
-                        "Cannot create instance of codec %s for parameter %s",
-                        codecClass, (paramName == null) ? paramIdx : paramName
-                ), e);
-            }
+            this.codec = codecClass == null || codecClass.equals(Defaults.NoCodec.class) ? null : (TypeCodec<Object>) ReflectionUtils.newInstance(codecClass);
         }
 
         void setValue(BoundStatement boundStatement, Object arg) {
