Fun with lambdas

mcostalba · mcostalba · commit 2ca2c3f35b2e · 2015-01-21T11:33:53.000+01:00
Use lambda functions instead of has_positive_value()
and toggle_case()

No functional change.
diff --git a/src/movepick.cpp b/src/movepick.cpp
@@ -49,10 +49,6 @@ namespace {
     }
   }
 
-  // Unary predicate used by std::partition to split positive values from remaining
-  // ones so as to sort the two sets separately, with the second sort delayed.
-  inline bool has_positive_value(const ExtMove& move) { return move.value > VALUE_ZERO; }
-
   // Picks the best move in the range (begin, end) and moves it to the front.
   // It's faster than sorting all the moves in advance when there are few
   // moves e.g. possible captures.
@@ -247,7 +243,7 @@ void MovePicker::generate_next_stage() {
   case QUIETS_1_S1:
       endQuiets = end = generate<QUIETS>(pos, moves);
       score<QUIETS>();
-      end = std::partition(cur, end, has_positive_value);
+      end = std::partition(cur, end, [](const ExtMove& m) { return m.value > VALUE_ZERO; });
       insertion_sort(cur, end);
       return;
 
diff --git a/src/position.cpp b/src/position.cpp
@@ -1147,10 +1147,6 @@ bool Position::is_draw() const {
 /// Position::flip() flips position with the white and black sides reversed. This
 /// is only useful for debugging e.g. for finding evaluation symmetry bugs.
 
-static char toggle_case(char c) {
-  return char(islower(c) ? toupper(c) : tolower(c));
-}
-
 void Position::flip() {
 
   string f, token;
@@ -1168,7 +1164,8 @@ void Position::flip() {
   ss >> token; // Castling availability
   f += token + " ";
 
-  std::transform(f.begin(), f.end(), f.begin(), toggle_case);
+  std::transform(f.begin(), f.end(), f.begin(),
+                 [](char c) { return char(islower(c) ? toupper(c) : tolower(c)); });
 
   ss >> token; // En passant square
   f += (token == "-" ? token : token.replace(1, 1, token[1] == '3' ? "6" : "3"));
diff --git a/src/ucioption.cpp b/src/ucioption.cpp
@@ -81,7 +81,7 @@ void init(OptionsMap& o) {
 std::ostream& operator<<(std::ostream& os, const OptionsMap& om) {
 
   for (size_t idx = 0; idx < om.size(); ++idx)
-      for (auto it : om)
+      for (auto& it : om)
           if (it.second.idx == idx)
           {
               const Option& o = it.second;

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ void init(OptionsMap& o) {`
`81`	`81`	`std::ostream& operator<<(std::ostream& os, const OptionsMap& om) {`
`82`	`82`
`83`	`83`	`for (size_t idx = 0; idx < om.size(); ++idx)`
`84`		`- for (auto it : om)`
	`84`	`+ for (auto& it : om)`
`85`	`85`	`if (it.second.idx == idx)`
`86`	`86`	`{`
`87`	`87`	`const Option& o = it.second;`