fix: update node-fetch to 3.x

RishikeshDarandale · RishikeshDarandale · commit 385868d9f7d7 · 2022-02-03T14:59:42.000+05:30
node-fetch is now ESM module only, thus this will be a breaking change and will requires at least Node.js 12.20.0. As suggested[1] by `node-fetch`, async import() function is used to load `node-fetch` asynchronously. BREAKING CHANGE: requires at least node 12.20.0 [1]: https://github.com/node-fetch/node-fetch#commonjs
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
     "cross-var": "^1.1.0",
     "eslint": "^3.13.1",
     "eslint-config-developit": "^1.1.1",
-    "jest": "^23.6.0",
+    "jest": "^27.4.7",
     "microbundle": "^0.10.1"
   }
 }
diff --git a/packages/isomorphic-unfetch/index.js b/packages/isomorphic-unfetch/index.js
@@ -1,6 +1,7 @@
 function r(m){return m && m.default || m;}
 module.exports = global.fetch = global.fetch || (
 	typeof process=='undefined' ? r(require('unfetch')) : (function(url, opts) {
-		return r(require('node-fetch'))(String(url).replace(/^\/\//g,'https://'), opts);
+		const fetch = (...args) => import('node-fetch').then(({default: fetch}) => fetch(...args));
+		return r(fetch)(String(url).replace(/^\/\//g,'https://'), opts);
 	})
 );
diff --git a/packages/isomorphic-unfetch/package-lock.json b/packages/isomorphic-unfetch/package-lock.json
diff --git a/packages/isomorphic-unfetch/package.json b/packages/isomorphic-unfetch/package.json
@@ -13,7 +13,7 @@
   "main": "index.js",
   "types": "index.d.ts",
   "dependencies": {
-    "node-fetch": "^2.6.1",
+    "node-fetch": "^3.2.0",
     "unfetch": "^4.2.0"
   }
 }
diff --git a/packages/isomorphic-unfetch/readme.md b/packages/isomorphic-unfetch/readme.md
@@ -6,6 +6,8 @@ Switches between [unfetch](https://github.com/developit/unfetch) & [node-fetch](
 
 This project uses [node](http://nodejs.org) and [npm](https://npmjs.com). Go check them out if you don't have them locally installed.
 
+> Note: This module uses node-fetch 3.x, which is ESM module and requires at least node 12.20.0.
+
 ```sh
 $ npm i isomorphic-unfetch
 ```
diff --git a/test/isomorphic.js b/test/isomorphic.js
@@ -112,7 +112,15 @@ describe('isomorphic-unfetch', () => {
 			sandbox.global.process = sandbox.process;
 			sandbox.module = { exports: sandbox.exports };
 			let filename = require.resolve('../packages/isomorphic-unfetch');
-			vm.runInNewContext(fs.readFileSync(filename), sandbox, filename);
+			vm.runInNewContext(fs.readFileSync(filename), sandbox, {
+				filename,
+				importModuleDynamically: () => {
+					const module = new vm.SyntheticModule(['node-fetch'], function() {
+						this.setExport('default', 'I AM NODE-FETCH');
+					  });
+					return module;
+				}
+			});
 
 			expect(sandbox.module.exports('/')).toBe(modules['node-fetch']('/'));
 		});

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@`
`61`	`61`	`"cross-var": "^1.1.0",`
`62`	`62`	`"eslint": "^3.13.1",`
`63`	`63`	`"eslint-config-developit": "^1.1.1",`
`64`		`- "jest": "^23.6.0",`
	`64`	`+ "jest": "^27.4.7",`
`65`	`65`	`"microbundle": "^0.10.1"`
`66`	`66`	`}`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`"main": "index.js",`
`14`	`14`	`"types": "index.d.ts",`
`15`	`15`	`"dependencies": {`
`16`		`- "node-fetch": "^2.6.1",`
	`16`	`+ "node-fetch": "^3.2.0",`
`17`	`17`	`"unfetch": "^4.2.0"`
`18`	`18`	`}`
`19`	`19`	`}`