ci: remove v8-profiler dependency

filipesilva · hansl · commit a1cdfda28d1d · 2018-06-05T17:55:16.000-07:00
It was adding 30s-1m to all CircleCI jobs, which is around half the time each take.

This way you must manually install the profiler before.
diff --git a/lib/bootstrap-local.js b/lib/bootstrap-local.js
@@ -22,7 +22,13 @@ if (process.env['CODE_COVERAGE'] || process.argv.indexOf('--code-coverage') !==
 // Check if we need to profile this CLI run.
 let profiler = null;
 if (process.env['DEVKIT_PROFILING']) {
-  profiler = require('v8-profiler');
+  try {
+    profiler = require('v8-profiler');
+  } catch (err) {
+    throw new Error(`Could not require 'v8-profiler'. You must install it separetely with` +
+      `'npm install v8-profiler --no-save.\n\nOriginal error:\n\n${err}`);
+  }
+
   profiler.startProfiling();
 
   function exitHandler(options, _err) {
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -147,8 +147,5 @@
   },
   "devDependencies": {
     "license-checker": "^16.0.0"
-  },
-  "optionalDependencies": {
-    "v8-profiler": "^5.7.0"
   }
 }
