Skip to content

Commit 1a17b57

Browse files
committed
fix context comparisons and log rekey errors
1 parent 8a734f2 commit 1a17b57

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/crypto.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,11 +313,14 @@ int sqlite3_rekey(sqlite3 *db, const void *pKey, int nKey) {
313313
rc = sqlite3PagerGet(pPager, pgno, &page);
314314
if(rc == SQLITE_OK) { /* write page see pager_incr_changecounter for example */
315315
rc = sqlite3PagerWrite(page);
316-
//printf("sqlite3PagerWrite(%d)\n", pgno);
317316
if(rc == SQLITE_OK) {
318317
sqlite3PagerUnref(page);
319-
}
320-
}
318+
} else {
319+
CODEC_TRACE(("sqlite3_rekey: error %d occurred writing page %d\n", rc, pgno));
320+
}
321+
} else {
322+
CODEC_TRACE(("sqlite3_rekey: error %d occurred getting page %d\n", rc, pgno));
323+
}
321324
}
322325
}
323326

src/crypto_impl.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ int sqlcipher_cipher_ctx_cmp(cipher_ctx *c1, cipher_ctx *c2) {
208208
&& c1->fast_kdf_iter == c2->fast_kdf_iter
209209
&& c1->key_sz == c2->key_sz
210210
&& c1->pass_sz == c2->pass_sz
211+
&& c1->use_hmac == c2->use_hmac
212+
&& c1->hmac_sz == c2->hmac_sz
211213
&& (
212214
c1->pass == c2->pass
213215
|| !sqlcipher_memcmp((const unsigned char*)c1->pass,

0 commit comments

Comments
 (0)