Skip to content

Commit 945863a

Browse files
committed
Fixes build order and lingering intermediate files.
1 parent 252e9ed commit 945863a

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

PCbuild/pcbuild.proj

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@
3333
<Projects Include="pythoncore.vcxproj">
3434
<BuildInParallel>false</BuildInParallel>
3535
</Projects>
36-
<!-- python[w].exe -->
37-
<Projects Include="python.vcxproj;pythonw.vcxproj" />
3836
<!-- python3.dll -->
3937
<Projects Include="python3dll.vcxproj" />
4038
<!-- py[w].exe -->
@@ -58,12 +56,18 @@
5856
<!-- Disable parallel build for test modules -->
5957
<BuildInParallel>false</BuildInParallel>
6058
</Projects>
59+
60+
<!-- python[w].exe -->
61+
<Projects Include="python.vcxproj;pythonw.vcxproj">
62+
<BuildInParallel>false</BuildInParallel>
63+
</Projects>
6164
</ItemGroup>
6265

6366
<Target Name="Build">
6467
<MSBuild Projects="@(Projects)"
6568
Properties="Configuration=%(Configuration);Platform=%(Platform);%(Properties)"
6669
BuildInParallel="%(BuildInParallel)"
70+
StopOnFirstFailure="true"
6771
Targets="%(BuildTarget)" />
6872
</Target>
6973

PCbuild/python3dll.vcxproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
<_ProjectFileVersion>10.0.30319.1</_ProjectFileVersion>
5959
<_Machine>X86</_Machine>
6060
<_Machine Condition="$(Platform) == 'x64'">X64</_Machine>
61+
<ExtensionsToDeleteOnClean>$(ExtensionsToDeleteOnClean);$(IntDir)python3_d.def;$(IntDir)python3stub.def</ExtensionsToDeleteOnClean>
6162
</PropertyGroup>
6263
<ItemDefinitionGroup>
6364
<ClCompile>
@@ -133,9 +134,4 @@
133134
<MakeDir Directories="$(IntDir)" />
134135
<WriteLinesToFile File="$(IntDir)python3stub.def" Lines="@(_Lines)" Overwrite="true" />
135136
</Target>
136-
<Target Name="_CleanStubDef" BeforeTargets="CoreClean">
137-
<ItemGroup>
138-
<Clean Include="$(IntDir)python3stub.def" />
139-
</ItemGroup>
140-
</Target>
141137
</Project>

0 commit comments

Comments
 (0)