bpo-38631: Avoid Py_FatalError() in _memory_release() (pythonGH-18214)

vstinner · web-flow · commit 47ee8a6063c2 · 2020-01-27T22:37:44.000+01:00
If the export count is negative, _memory_release() now raises a
SystemError and returns -1, rather than calling Py_FatalError()
which aborts the process.
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
@@ -1048,7 +1048,8 @@ _memory_release(PyMemoryViewObject *self)
         return -1;
     }
 
-    Py_FatalError("_memory_release(): negative export count");
+    PyErr_SetString(PyExc_SystemError,
+                    "_memory_release(): negative export count");
     return -1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1048,7 +1048,8 @@ _memory_release(PyMemoryViewObject *self)`
`1048`	`1048`	`return -1;`
`1049`	`1049`	`}`
`1050`	`1050`
`1051`		`- Py_FatalError("_memory_release(): negative export count");`
	`1051`	`+ PyErr_SetString(PyExc_SystemError,`
	`1052`	`+ "_memory_release(): negative export count");`
`1052`	`1053`	`return -1;`
`1053`	`1054`	`}`
`1054`	`1055`