Fixing Some Nits in Tests (firebase#39)

hiranya911 · web-flow · commit 35a6174415a7 · 2017-06-26T12:56:25.000-07:00
* Adding integration tests to the linter. Minor update to a db integration test.

* Fixing linter script

* Adding the unused-argument check back
diff --git a/integration/test_db.py b/integration/test_db.py
@@ -49,6 +49,7 @@ def testref(update_rules):
     Returns:
         Reference: A reference to the test dinosaur database.
     """
+    del update_rules
     ref = db.reference('_adminsdk/python/dinodb')
     ref.set(testdata())
     return ref
@@ -138,10 +139,15 @@ def test_update_children_with_existing_values(self, testref):
 
     def test_update_nested_children(self, testref):
         python = testref.parent
-        ref = python.child('users').push({'name' : 'Edward Cope', 'since' : 1800})
-        nested_key = '{0}/since'.format(ref.key)
-        python.child('users').update({nested_key: 1840})
-        assert ref.get() == {'name' : 'Edward Cope', 'since' : 1840}
+        edward = python.child('users').push({'name' : 'Edward Cope', 'since' : 1800})
+        jack = python.child('users').push({'name' : 'Jack Horner', 'since' : 1940})
+        delta = {
+            '{0}/since'.format(edward.key) : 1840,
+            '{0}/since'.format(jack.key) : 1946
+        }
+        python.child('users').update(delta)
+        assert edward.get() == {'name' : 'Edward Cope', 'since' : 1840}
+        assert jack.get() == {'name' : 'Jack Horner', 'since' : 1946}
 
     def test_delete(self, testref):
         python = testref.parent
@@ -233,6 +239,7 @@ def test_filter_by_value(self, testref):
 
 @pytest.fixture(scope='module')
 def override_app(request, update_rules):
+    del update_rules
     cred, project_id = conftest.integration_conf(request)
     ops = {
         'databaseURL' : 'https://{0}.firebaseio.com'.format(project_id),
@@ -244,6 +251,7 @@ def override_app(request, update_rules):
 
 @pytest.fixture(scope='module')
 def none_override_app(request, update_rules):
+    del update_rules
     cred, project_id = conftest.integration_conf(request)
     ops = {
         'databaseURL' : 'https://{0}.firebaseio.com'.format(project_id),
diff --git a/lint.sh b/lint.sh
@@ -48,7 +48,9 @@ if [[ "$CHECK_ALL" = true ]]
 then
   lintAllFiles "firebase_admin" ""
   lintAllFiles "tests" "$SKIP_FOR_TESTS"
+  lintAllFiles "integration" "$SKIP_FOR_TESTS"
 else
   lintChangedFiles "firebase_admin" ""
   lintChangedFiles "tests" "$SKIP_FOR_TESTS"
+  lintChangedFiles "integration" "$SKIP_FOR_TESTS"
 fi
diff --git a/tests/test_credentials.py b/tests/test_credentials.py
@@ -81,7 +81,8 @@ class TestApplicationDefault(object):
 
     @pytest.mark.parametrize('app_default', [testutils.resource_filename('service_account.json')],
                              indirect=True)
-    def test_init(self, app_default): # pylint: disable=unused-argument
+    def test_init(self, app_default):
+        del app_default
         credential = credentials.ApplicationDefault()
         assert credential.project_id == 'mock-project-id'
 
@@ -98,7 +99,8 @@ def test_init(self, app_default): # pylint: disable=unused-argument
 
     @pytest.mark.parametrize('app_default', [testutils.resource_filename('non_existing.json')],
                              indirect=True)
-    def test_nonexisting_path(self, app_default): # pylint: disable=unused-argument
+    def test_nonexisting_path(self, app_default):
+        del app_default
         with pytest.raises(IOError):
             credentials.ApplicationDefault()
 
diff --git a/tests/test_db.py b/tests/test_db.py
@@ -36,7 +36,8 @@ def __init__(self, data, status, recorder):
         self._status = status
         self._recorder = recorder
 
-    def send(self, request, **kwargs): # pylint: disable=unused-argument
+    def send(self, request, **kwargs):
+        del kwargs
         self._recorder.append(request)
         resp = models.Response()
         resp.url = request.url
