Added try/finally block to method com.mongodb.gridfs.GridFSDBFile.writeTo( File f ) which closes the

breinero-zz · breinero-zz · commit e19ec503166e · 2012-03-30T17:37:11.000-04:00
an OutputStream instantiated at the beginning of the method. Properly closing the output stream addresses a potential memory leak.
diff --git a/src/main/com/mongodb/gridfs/GridFSDBFile.java b/src/main/com/mongodb/gridfs/GridFSDBFile.java
@@ -64,7 +64,15 @@ public long writeTo( String filename ) throws IOException {
      * @throws IOException
      */
     public long writeTo( File f ) throws IOException {
-        return writeTo( new FileOutputStream( f ) );
+    	
+    	FileOutputStream out = null;
+    	try{
+    		out = new FileOutputStream( f );
+    		return writeTo( out);
+    	}finally{
+    	    if(out != null)
+    	        out.close();
+    	}
     }
 
     /**
@@ -74,12 +82,12 @@ public long writeTo( File f ) throws IOException {
      * @throws IOException
      */
     public long writeTo( OutputStream out )
-        throws IOException {
-        final int nc = numChunks();
-        for ( int i=0; i<nc; i++ ){
-            out.write( getChunk( i ) );
-        }
-        return _length;
+    		throws IOException {
+    	final int nc = numChunks();
+    	for ( int i=0; i<nc; i++ ){
+    	    out.write( getChunk( i ) );
+    	}
+    	return _length;
     }
     
     byte[] getChunk( int i ){
