Fixing NumberFormatException when parsing http:// address

neerajbhatt · rozza · commit b844c523143f · 2014-08-12T14:38:24.000+01:00
https://jira.mongodb.org/browse/JAVA-913 Fixed, When http:// address is given to MongoClient, it now throws a MongoException as told by Jeff Refs JAVA-1357
diff --git a/src/main/com/mongodb/ServerAddress.java b/src/main/com/mongodb/ServerAddress.java
@@ -79,11 +79,15 @@ public ServerAddress( String host , int port )
         }
         else {
             int idx = host.indexOf( ":" );
-            if ( idx > 0 ){
-                if ( port != defaultPort() )
-                    throw new IllegalArgumentException( "can't specify port in construct and via host" );
-                port = Integer.parseInt( host.substring( idx + 1 ) );
-                host = host.substring( 0 , idx ).trim();
+            if (idx > 0) {
+                if (port != defaultPort())
+                    throw new IllegalArgumentException("can't specify port in construct and via host");
+                try {
+                    port = Integer.parseInt(host.substring(idx + 1));
+                } catch (NumberFormatException e) {
+                    throw new MongoException("host and port should be specified in host:port format");
+                }
+                host = host.substring(0, idx).trim();
             }
         }
 
diff --git a/src/test/com/mongodb/ServerAddressTest.java b/src/test/com/mongodb/ServerAddressTest.java
@@ -129,4 +129,9 @@ public void testParseWithPortWhenEquivalentPortIsAlsoSpecified() throws UnknownH
     public void testParseWithPortWhenNonEquivalentPortIsAlsoSpecified() throws UnknownHostException {
         new ServerAddress("somewhere:80", 1000);
     }
-}
+
+    @Test(expected = MongoException.class)
+    public void testParseUrlWithMissingPort() throws UnknownHostException {
+        new ServerAddress("mongodb://somewhere/");
+    }
+}
