Skip to content

Commit 6f63f8d

Browse files
apapirovskiapapirovski
committed
test: remove outdated, non-functioning test
The timers directory test, utilizing FakeTime, has not worked in quite a while and is not truly testing Node.js behaviour. If a similar test is necessary it would be better suited to libuv on which Node.js relies for timers functionality. PR-URL: nodejs#20894 Fixes: nodejs#10154 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
1 parent 1e7ff81 commit 6f63f8d

File tree

5 files changed

+0
-182
lines changed

5 files changed

+0
-182
lines changed

‎.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ deps/npm/node_modules/.bin/
106106
/SHASUMS*.txt*
107107

108108
# test artifacts
109-
tools/faketime
110109
tools/remark-cli/node_modules
111110
tools/remark-preset-lint-node/node_modules
112111
icu_config.gypi

‎Makefile‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -516,13 +516,6 @@ test-addons-clean:
516516
$(RM) test/addons/.buildstamp test/addons/.docbuildstamp
517517
$(MAKE) test-addons-napi-clean
518518

519-
test-timers:
520-
$(MAKE) --directory=tools faketime
521-
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) timers
522-
523-
test-timers-clean:
524-
$(MAKE) --directory=tools clean
525-
526519
test-async-hooks:
527520
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) async-hooks
528521

‎test/timers/test-timers-reliability.js‎

Lines changed: 0 additions & 54 deletions
This file was deleted.

‎test/timers/testcfg.py‎

Lines changed: 0 additions & 100 deletions
This file was deleted.

‎tools/Makefile‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)