Describe the bug
According to the docstring here, the incremental snapshot update starts listing from the previous checkpoint, or the existing snapshot version if there is no checkpoint:
|
/// 3. list from (existing checkpoint version + 1) onward (or just existing snapshot version if |
What I would expect is: if the existing snapshot version is higher than the last checkpoint, listing would start from the existing snapshot. Unless I misunderstand the protocol completely.
But further, int the implementation, listing starts from the previous checkpoint, or from zero if there is no checkpoint. So this is not incremental at all if there are no checkpoints.
Seems that if this is indeed a bug, it could be a oneliner fix, to use max(0, max(checkpoint_version, current_version)) as the starting point?
To Reproduce
No response
Expected behavior
No response
Additional context
No response
Describe the bug
According to the docstring here, the incremental snapshot update starts listing from the previous checkpoint, or the existing snapshot version if there is no checkpoint:
delta-kernel-rs/kernel/src/snapshot.rs
Line 110 in 876c2a4
What I would expect is: if the existing snapshot version is higher than the last checkpoint, listing would start from the existing snapshot. Unless I misunderstand the protocol completely.
But further, int the implementation, listing starts from the previous checkpoint, or from zero if there is no checkpoint. So this is not incremental at all if there are no checkpoints.
Seems that if this is indeed a bug, it could be a oneliner fix, to use
max(0, max(checkpoint_version, current_version))as the starting point?To Reproduce
No response
Expected behavior
No response
Additional context
No response