Fix: Allow dot as windows domain for local authentication (BornToBeRoot#2305)

BornToBeRoot · web-flow · commit e33af04740ca · 2023-05-25T21:19:22.000Z
* Fix: Allow dot as windows domain for local authentication * Docs: BornToBeRoot#2305
diff --git a/Source/NETworkManager.Validators/EmptyOrWindowsDomainValidator.cs b/Source/NETworkManager.Validators/EmptyOrWindowsDomainValidator.cs
@@ -10,9 +10,15 @@ public class EmptyOrWindowsDomainValidator : ValidationRule
 {
     public override ValidationResult Validate(object value, CultureInfo cultureInfo)
     {
-        if (string.IsNullOrEmpty(value as string))
+        string domain = value as string;
+
+        if (string.IsNullOrEmpty(domain))
             return ValidationResult.ValidResult;
 
-        return Regex.IsMatch((string)value, RegexHelper.HostnameRegex) ? ValidationResult.ValidResult : new ValidationResult(false, Strings.EnterValidDomain);        
+        // For local authentication "." is a valid domain
+        if (domain.Equals("."))
+            return ValidationResult.ValidResult;
+        
+        return Regex.IsMatch(domain, RegexHelper.HostnameRegex) ? ValidationResult.ValidResult : new ValidationResult(false, Strings.EnterValidDomain);        
     }
 }
diff --git a/docs/Changelog/next-release.md b/docs/Changelog/next-release.md
@@ -30,10 +30,12 @@ Breaking changes
 
 - DNS Lookup
   - Improved validation when adding/changing DNS server profiles [#2282](https://github.com/BornToBeRoot/NETworkManager/pull/2282){:target="\_blank"}
-- SNTP Lookup
-  - Improved validation when adding/changing SNTP server profiles [#2282](https://github.com/BornToBeRoot/NETworkManager/pull/2282){:target="\_blank"}
+- Remote Desktop
+  - Allow `.` as domain to authenticate with local accounts [#2305](https://github.com/BornToBeRoot/NETworkManager/pull/2305){:target="\_blank"}
 - TigerVNC
   - Use port from default config instead of settings if creating a new group [#2249](https://github.com/BornToBeRoot/NETworkManager/pull/2249){:target="\_blank"}
+- SNTP Lookup
+  - Improved validation when adding/changing SNTP server profiles [#2282](https://github.com/BornToBeRoot/NETworkManager/pull/2282){:target="\_blank"}
 - Wake on LAN
   - Change default port from 7 to 9 [#2242](https://github.com/BornToBeRoot/NETworkManager/pull/2242){:target="\_blank"}
 

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,15 @@ public class EmptyOrWindowsDomainValidator : ValidationRule`
`10`	`10`	`{`
`11`	`11`	`public override ValidationResult Validate(object value, CultureInfo cultureInfo)`
`12`	`12`	`{`
`13`		`- if (string.IsNullOrEmpty(value as string))`
	`13`	`+ string domain = value as string;`
	`14`	`+`
	`15`	`+ if (string.IsNullOrEmpty(domain))`
`14`	`16`	`return ValidationResult.ValidResult;`
`15`	`17`
`16`		`- return Regex.IsMatch((string)value, RegexHelper.HostnameRegex) ? ValidationResult.ValidResult : new ValidationResult(false, Strings.EnterValidDomain);`
	`18`	`+ // For local authentication "." is a valid domain`
	`19`	`+ if (domain.Equals("."))`
	`20`	`+ return ValidationResult.ValidResult;`
	`21`	`+`
	`22`	`+ return Regex.IsMatch(domain, RegexHelper.HostnameRegex) ? ValidationResult.ValidResult : new ValidationResult(false, Strings.EnterValidDomain);`
`17`	`23`	`}`
`18`	`24`	`}`