Enable LTO on the Linux Clang build on CI (WebAssembly#3491)

dschuff · web-flow · commit f18c18e01d03 · 2021-01-14T15:57:52.000-08:00
Also adjust the check for Clang to also match AppleClang
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -101,7 +101,7 @@ jobs:
       run: python check.py --binaryen-bin=out/bin
 
   build-clang:
-    name: clang
+    name: clang (LTO)
     runs-on: ubuntu-latest
     steps:
     - uses: actions/setup-python@v1
@@ -115,9 +115,9 @@ jobs:
     - name: cmake
       run: |
         mkdir -p out
-        cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
+        cmake -S . -B out -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DBYN_ENABLE_LTO=ON
     - name: build
-      run: cmake --build out
+      run: cmake --build out -v
     - name: test binaryen-lit
       run: python out/bin/binaryen-lit test/lit/parse-error.wast
     - name: test
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -137,7 +137,7 @@ ENDFOREACH()
 
 option(BYN_ENABLE_LTO "Build with LTO" Off)
 if(BYN_ENABLE_LTO)
-  if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+  if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     message(FATAL_ERROR "ThinLTO is only supported by clang")
   endif()
   if(NOT APPLE)
