fix: formatting directive bugs in test (bazel-contrib#2134)

tokongs · aignas · web-flow · commit bdcf53a7a0a0 · 2024-08-21T13:21:47.000Z
I'm getting a build error in my builds because nogo complains about this
bug. I guess I could configure my nogo to no check this code, but I
think it should be fixed.

---------

Co-authored-by: Ignas Anikevicius &lt;240938+aignas@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,9 @@ A brief description of the categories of changes:
 ### Changed
 * Nothing yet
 
+### Fixed
+* (gazelle): Fix incorrect use of `t.Fatal`/`t.Fatalf` in tests.
+
 ### Added
 * Nothing yet
 
diff --git a/gazelle/manifest/test/test.go b/gazelle/manifest/test/test.go
@@ -33,12 +33,12 @@ import (
 func TestGazelleManifestIsUpdated(t *testing.T) {
 	requirementsPath := os.Getenv("_TEST_REQUIREMENTS")
 	if requirementsPath == "" {
-		t.Fatalf("_TEST_REQUIREMENTS must be set")
+		t.Fatal("_TEST_REQUIREMENTS must be set")
 	}
 
 	manifestPath := os.Getenv("_TEST_MANIFEST")
 	if manifestPath == "" {
-		t.Fatalf("_TEST_MANIFEST must be set")
+		t.Fatal("_TEST_MANIFEST must be set")
 	}
 
 	manifestFile := new(manifest.File)
@@ -53,7 +53,7 @@ func TestGazelleManifestIsUpdated(t *testing.T) {
 	manifestGeneratorHashPath, err := runfiles.Rlocation(
 		os.Getenv("_TEST_MANIFEST_GENERATOR_HASH"))
 	if err != nil {
-		t.Fatal("failed to resolve runfiles path of manifest: %v", err)
+		t.Fatalf("failed to resolve runfiles path of manifest: %v", err)
 	}
 
 	manifestGeneratorHash, err := os.Open(manifestGeneratorHashPath)
