fix: correctly check the arg count in precompiler.py (bazel-contrib#2165)

oprypin · web-flow · commit 31e4771c52c2 · 2024-08-29T16:36:17.000Z
This is supposed to check that all argument counts are equal, but due to
an incorrect inversion of the conditional, it was checking that *any*
pair of argument counts is equal
diff --git a/tools/precompiler/precompiler.py b/tools/precompiler/precompiler.py
@@ -48,7 +48,7 @@ def _compile(options: "argparse.Namespace") -> None:
             f"Unknown PycInvalidationMode: {options.invalidation_mode}"
         ) from e
 
-    if len(options.srcs) != len(options.src_names) != len(options.pycs):
+    if not (len(options.srcs) == len(options.src_names) == len(options.pycs)):
         raise AssertionError(
             "Mismatched number of --src, --src_name, and/or --pyc args"
         )

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ def _compile(options: "argparse.Namespace") -> None:`
`48`	`48`	`f"Unknown PycInvalidationMode: {options.invalidation_mode}"`
`49`	`49`	`) from e`
`50`	`50`
`51`		`- if len(options.srcs) != len(options.src_names) != len(options.pycs):`
	`51`	`+ if not (len(options.srcs) == len(options.src_names) == len(options.pycs)):`
`52`	`52`	`raise AssertionError(`
`53`	`53`	`"Mismatched number of --src, --src_name, and/or --pyc args"`
`54`	`54`	`)`