fix: Address PR review feedback from @dreamorosi

dcabib · dcabib · commit e2d934f0afb3 · 2025-09-22T14:22:45.000-03:00
- Remove .sonarcloud.properties changes (keep SonarCloud rules strict) - Remove LambdaHandlerProcessor.java changes (belong in PR aws-powertools#2124) - Remove LambdaConstants.java changes (belong in PR aws-powertools#2124) - Keep PR focused only on CRaC tracing functionality - Maintain GraalVM compatibility fixes for CRaC tracing SpotBugs exclusions are justified for CRaC beforeCheckpoint methods which intentionally ignore return values during priming operations.
diff --git a/.sonarcloud.properties b/.sonarcloud.properties
@@ -15,9 +15,3 @@ sonar.exclusions=examples/**/*,powertools-e2e-tests/handlers/**/*
 
 # Ignore code duplicates in the examples
 sonar.cpd.exclusions=examples/**/*,powertools-e2e-tests/**/*
-
-# Ignore singleton pattern detection for CRaC Resource implementations
-# Singleton pattern is required for CRaC (Coordinated Restore at Checkpoint) Resource interface
-sonar.issue.ignore.multicriteria=e1
-sonar.issue.ignore.multicriteria.e1.ruleKey=java:S6548
-sonar.issue.ignore.multicriteria.e1.resourceKey=**/TracingUtils.java,**/JsonConfig.java
diff --git a/powertools-common/src/main/java/software/amazon/lambda/powertools/common/internal/LambdaConstants.java b/powertools-common/src/main/java/software/amazon/lambda/powertools/common/internal/LambdaConstants.java
@@ -23,6 +23,4 @@ public class LambdaConstants {
     public static final String ROOT_EQUALS = "Root=";
     public static final String POWERTOOLS_SERVICE_NAME = "POWERTOOLS_SERVICE_NAME";
     public static final String SERVICE_UNDEFINED = "service_undefined";
-    public static final String AWS_LAMBDA_INITIALIZATION_TYPE = "AWS_LAMBDA_INITIALIZATION_TYPE";
-    public static final String PROVISIONED_CONCURRENCY = "provisioned-concurrency";
 }
diff --git a/powertools-common/src/main/java/software/amazon/lambda/powertools/common/internal/LambdaHandlerProcessor.java b/powertools-common/src/main/java/software/amazon/lambda/powertools/common/internal/LambdaHandlerProcessor.java
@@ -88,10 +88,7 @@ protected static void resetServiceName() {
     }
 
     public static boolean isColdStart() {
-        // If this is not the first invocation, it's definitely not a cold start
-        // Check if this execution environment was pre-warmed via provisioned concurrency
-        // Traditional cold start detection - first invocation without provisioned concurrency
-        return IS_COLD_START == null && !LambdaConstants.PROVISIONED_CONCURRENCY.equals(getenv(LambdaConstants.AWS_LAMBDA_INITIALIZATION_TYPE));
+        return IS_COLD_START == null;
     }
 
     public static void coldStartDone() {

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,4 @@ public class LambdaConstants {`
`23`	`23`	`public static final String ROOT_EQUALS = "Root=";`
`24`	`24`	`public static final String POWERTOOLS_SERVICE_NAME = "POWERTOOLS_SERVICE_NAME";`
`25`	`25`	`public static final String SERVICE_UNDEFINED = "service_undefined";`
`26`		`- public static final String AWS_LAMBDA_INITIALIZATION_TYPE = "AWS_LAMBDA_INITIALIZATION_TYPE";`
`27`		`- public static final String PROVISIONED_CONCURRENCY = "provisioned-concurrency";`
`28`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,10 +88,7 @@ protected static void resetServiceName() {`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`public static boolean isColdStart() {`
`91`		`- // If this is not the first invocation, it's definitely not a cold start`
`92`		`- // Check if this execution environment was pre-warmed via provisioned concurrency`
`93`		`- // Traditional cold start detection - first invocation without provisioned concurrency`
`94`		`- return IS_COLD_START == null && !LambdaConstants.PROVISIONED_CONCURRENCY.equals(getenv(LambdaConstants.AWS_LAMBDA_INITIALIZATION_TYPE));`
	`91`	`+ return IS_COLD_START == null;`
`95`	`92`	`}`
`96`	`93`
`97`	`94`	`public static void coldStartDone() {`